Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert instead of ! for nullable #11545

Merged
merged 1 commit into from
Mar 20, 2025
Merged

Assert instead of ! for nullable #11545

merged 1 commit into from
Mar 20, 2025

Conversation

rainersigwald
Copy link
Member

Minor nitpick about #11537.

@rainersigwald
Copy link
Member Author

Test failure from Build_WithCustomBuildArgs_ShouldEmitWarningOnFramework is

The provided expression
    should have single item but had
1
    items and was
[Microsoft.Build.Framework.BuildWarningEventArgs (64925097)]

Which . . . what? Retrying.

@rainersigwald rainersigwald self-assigned this Mar 5, 2025
@JanProvaznik JanProvaznik merged commit 88496b9 into dotnet:main Mar 20, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanProvaznik JanProvaznik JanProvaznik approved these changes

@YuliiaKovalova YuliiaKovalova YuliiaKovalova approved these changes

Assignees

@rainersigwald rainersigwald

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rainersigwald @JanProvaznik @YuliiaKovalova