-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Update runtime packages from 9.0.11 to 10.0.0 (WIP - Dependency conflicts) #12907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: rainersigwald <[email protected]>
|
@copilot fix the restore errors |
- Update eng/Versions.props: SystemMemory, SystemRuntimeCompilerServicesUnsafe, SystemThreadingTasksExtensions from 4.6.0/6.1.0/4.6.0 to 4.6.3/6.1.2/4.6.3 - Update src/Directory.Build.targets: Update frozen maintenance package versions to match 10.0.0 package requirements - Update binding redirects in app.config and app.amd64.config for System.Numerics.Vectors to 4.1.6.0 Co-authored-by: rainersigwald <[email protected]>
Fixed in commit f7f9854. The 10.0.0 runtime packages require updated dependency versions:
Updated eng/Versions.props, src/Directory.Build.targets, and binding redirects in app.config/app.amd64.config. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
The 4.6.x versions of System.* packages use net462 target framework folders, not net461/net46. Updated Directory.Build.targets to reference the correct paths. Co-authored-by: rainersigwald <[email protected]>
src/Directory.Build.targets
Outdated
| <FrozenSystemMemoryVersion>4.6.3</FrozenSystemMemoryVersion> | ||
| <FrozenSystemRuntimeCompilerServicesUnsafeVersion>6.1.2</FrozenSystemRuntimeCompilerServicesUnsafeVersion> | ||
| <FrozenSystemThreadingTasksExtensionsVersion>4.6.3</FrozenSystemThreadingTasksExtensionsVersion> | ||
| <FrozenSystemBuffersVersion>4.6.1</FrozenSystemBuffersVersion> | ||
| <FrozenSystemNumericsVectorsVersion>4.6.1</FrozenSystemNumericsVectorsVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot do not update these versions. They're frozen for important reasons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted frozen versions in commit [pending]. However, the 10.0.0 runtime packages have incompatible dependency requirements:
- System.Text.Json 10.0.0 → requires System.Memory 4.6.3 (frozen: 4.5.5)
- System.Collections.Immutable 10.0.0 → requires System.Runtime.CompilerServices.Unsafe 6.1.2 (frozen: 6.0.0)
The build fails with assembly version conflicts. Should I:
- Revert the entire runtime package update to 9.0.11?
- Keep eng/Versions.props updates (4.6.3/6.1.2/4.6.3) without frozen version changes?
- Another approach?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the eng/versions.props updates but do not change the frozen versions.
Do not update frozen maintenance package versions as they are frozen for important reasons. Reverted Directory.Build.targets to original state before my changes. Note: Build currently fails with dependency conflicts between 10.0.0 runtime packages and frozen maintenance package versions. Awaiting guidance on resolution approach. Co-authored-by: rainersigwald <[email protected]>
Context
Updates MSBuild's System.* runtime package references from 9.0.11 to 10.0.0, following the pattern established in #12771.
The 10.0.0 runtime packages have higher dependency requirements that are incompatible with the frozen maintenance package versions (which must remain frozen for important compatibility reasons).
Changes Made
Updated 17 runtime packages and their dependencies across 6 files:
Runtime Package Updates (9.0.11 → 10.0.0):
Dependency Version Updates (required by 10.0.0 packages):
Frozen maintenance package versions in src/Directory.Build.targets remain unchanged per review feedback (lines 153-157), as they are frozen for important compatibility reasons.
Affected packages: System.CodeDom, System.Collections.Immutable, System.Configuration.ConfigurationManager, System.Diagnostics.DiagnosticSource, System.Diagnostics.EventLog, System.Formats.Asn1, System.Formats.Nrbf, System.Reflection.Metadata, System.Reflection.MetadataLoadContext, System.Resources.Extensions, System.Security.Cryptography.Pkcs, System.Security.Cryptography.ProtectedData, System.Security.Cryptography.Xml, System.Text.Encoding.CodePages, System.Text.Json, System.Threading.Channels, System.Threading.Tasks.Dataflow
Testing
Notes
6 files changed. The scope expanded beyond #12771 to include centrally managed dependency version updates in eng/Versions.props.
Blocking Issue: The 10.0.0 runtime packages have dependency requirements that conflict with the frozen maintenance package versions (System.Memory 4.5.5, System.Runtime.CompilerServices.Unsafe 6.0.0, etc.). The frozen versions cannot be updated as they are frozen for important compatibility reasons. Resolution approach needed.
Original prompt
This pull request was created as a result of the following prompt from Copilot chat.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.