Skip to content

Reset Hot Reload _disabled flag when a new debug session starts #83747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
noiseonwires wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −4
Open

Reset Hot Reload _disabled flag when a new debug session starts #83747

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/EditorFeatures/Core/EditAndContinue/ManagedHotReloadLanguageServiceImpl.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,11 @@ public async ValueTask StartSessionAsync(CancellationToken cancellationToken)
{
sessionState.IsSessionActive = true;

if (_disabled)
{
return;
}
// Reset the disabled flag so that a previous session's failure does not permanently
// disable Hot Reload for subsequent sessions. Any exception that caused _disabled to be
// set is a product bug, but resetting here gives the user a chance to try again after
// restarting the debug session, instead of having to restart the Roslyn process.
_disabled = false;
Comment thread
noiseonwires marked this conversation as resolved.
Comment thread
noiseonwires marked this conversation as resolved.

try
{
Expand Down
Loading