-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[release/7.0-rc1] Change signature for diagnostic binaries (#74323)
* Add DAC signature infrastructure * Use a .NET 6 SDK to enable signing * Add signature verification Co-authored-by: Juan Sebastian Hoyos Ayala <[email protected]>
- Loading branch information
1 parent
d8e8436
commit e69c9d0
Showing
5 changed files
with
101 additions
and
74 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| parameters: | ||
| basePath: '' | ||
| isOfficialBuild: '' | ||
| timeoutInMinutes: '' | ||
|
|
||
| steps: | ||
| - ${{ if and(eq(parameters.isOfficialBuild, true), ne(variables['Build.Reason'], 'PullRequest')) }}: | ||
| - task: UseDotNet@2 | ||
| displayName: Install .NET 6 SDK for signing. | ||
| inputs: | ||
| packageType: 'sdk' | ||
| version: '6.0.x' | ||
| installationPath: '$(Agent.TempDirectory)/dotnet' | ||
|
|
||
| - task: EsrpCodeSigning@1 | ||
| displayName: Sign Diagnostic Binaries | ||
| inputs: | ||
| ConnectedServiceName: 'dotnetesrp-diagnostics-dnceng' | ||
| FolderPath: ${{ parameters.basePath }} | ||
| Pattern: | | ||
| **/mscordaccore*.dll | ||
| **/mscordbi*.dll | ||
| UseMinimatch: true | ||
| signConfigType: 'inlineSignParams' | ||
| inlineOperation: >- | ||
| [ | ||
| { | ||
| "keyCode": "CP-471322", | ||
| "operationCode": "SigntoolSign", | ||
| "parameters": { | ||
| "OpusName": "Microsoft", | ||
| "OpusInfo": "http://www.microsoft.com", | ||
| "PageHash": "/NPH", | ||
| "FileDigest": "/fd sha256", | ||
| "TimeStamp": "/tr \"http://rfc3161.gtm.corp.microsoft.com/TSS/HttpTspServer\" /td sha256" | ||
| }, | ||
| "toolName": "sign", | ||
| "toolVersion": "1.0" | ||
| }, | ||
| { | ||
| "KeyCode": "CP-471322", | ||
| "OperationCode": "SigntoolVerify", | ||
| "Parameters": {}, | ||
| "ToolName": "sign", | ||
| "ToolVersion": "1.0" | ||
| } | ||
| ] | ||
| SessionTimeout: ${{ parameters.timeoutInMinutes }} | ||
| MaxConcurrency: '50' | ||
| MaxRetryAttempts: '5' | ||
| env: | ||
| DOTNET_MULTILEVEL_LOOKUP: 0 | ||
| DOTNET_ROOT: '$(Agent.TempDirectory)/dotnet' | ||
| DOTNET_MSBUILD_SDK_RESOLVER_CLI_DIR: '$(Agent.TempDirectory)/dotnet' | ||
|
|
||
| - powershell: | | ||
| $filesToSign = $(Get-ChildItem -Recurse ${{ parameters.basePath }} -Include mscordaccore*.dll, mscordbi*.dll) | ||
| foreach ($file in $filesToSign) { | ||
| $signingCert = $(Get-AuthenticodeSignature $file).SignerCertificate | ||
| if ($signingCert -eq $null) | ||
| { | ||
| throw "File $file does not contain a signature." | ||
| } | ||
| if ($signingCert.Subject -ne "CN=.NET DAC, O=Microsoft Corporation, L=Redmond, S=Washington, C=US" ` | ||
| -or $signingCert.Issuer -ne "CN=Microsoft Code Signing PCA 2010, O=Microsoft Corporation, L=Redmond, S=Washington, C=US") | ||
| { | ||
| throw "File $file not in expected trust chain." | ||
| } | ||
| $certEKU = $signingCert.Extensions.Where({ $_.Oid.FriendlyName -eq "Enhanced Key Usage" }) | Select -First 1 | ||
| if ($certEKU.EnhancedKeyUsages.Where({ $_.Value -eq "1.3.6.1.4.1.311.84.4.1" }).Count -ne 1) | ||
| { | ||
| throw "Signature for $file does not contain expected EKU." | ||
| } | ||
| Write-Host "$file is correctly signed." | ||
| } | ||
| displayName: Validate diagnostic signatures |