Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused build controls and simplify DotNetBuild.props #111986

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

jkoritzinsky
Copy link
Member

Remove controls that aren't used in the VMR. Don't override the "inner source build command" so we get globally set properties for free like every other repo in the VMR.

@jkoritzinsky jkoritzinsky added source-build Issues relating to dotnet/source-build area-Infrastructure labels Jan 29, 2025
@jkoritzinsky jkoritzinsky requested review from ViktorHofer and a team January 29, 2025 23:53
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@mmitche
Copy link
Member

mmitche commented Jan 30, 2025

Do you have VMR/source builds with these changes?

eng/DotNetBuild.props Outdated Show resolved Hide resolved
…f property sets we had to do to work around overriding it."

This reverts commit 4fbfd7c.
@jkoritzinsky jkoritzinsky merged commit ad7b829 into dotnet:main Jan 31, 2025
157 of 159 checks passed
@jkoritzinsky jkoritzinsky deleted the simplify-dotnetbuild-props branch January 31, 2025 23:26
grendello added a commit to grendello/runtime that referenced this pull request Feb 3, 2025
* main:
  System.Net.Http.WinHttpHandler.StartRequestAsync assertion failed (dotnet#109799)
  Keep test PDB in helix payload for native AOT (dotnet#111949)
  Build the RID-specific System.IO.Ports packages in the VMR (dotnet#112054)
  Always inline number conversions (dotnet#112061)
  Use Contains{Any} in Regex source generator (dotnet#112065)
  Update dependencies from https://github.com/dotnet/arcade build 20250130.5 (dotnet#112013)
  JIT: Transform single-reg args to FIELD_LIST in physical promotion (dotnet#111590)
  Ensure that math calls into the CRT are tracked as needing vzeroupper (dotnet#112011)
  Use double.ConvertToIntegerNative where safe to do in System.Random (dotnet#112046)
  JIT: Compute `fgCalledCount` after synthesis (dotnet#112041)
  Simplify boolean logic in `TimeZoneInfo` (dotnet#112062)
  JIT: Update type when return temp is freshly created (dotnet#111948)
  Remove unused build controls and simplify DotNetBuild.props (dotnet#111986)
  Fix case-insensitive JSON deserialization of enum member names (dotnet#112028)
  WasmAppBuilder: Remove double computation of a value (dotnet#112047)
  Disable LTCG for brotli and zlibng. (dotnet#111805)
  JIT: Improve x86 unsigned to floating cast codegen (dotnet#111595)
  simplify x86 special intrinsic imports (dotnet#111836)
  JIT: Try to retain entry weight during profile synthesis (dotnet#111971)
  Fix explicit offset of ByRefLike fields. (dotnet#111584)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Infrastructure source-build Issues relating to dotnet/source-build
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants