JIT: Rework retbuf handling during inlining #112010
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid directly capturing the return buffer from the call in the inliner; instead record an actual `InlArgInfo` entry for the retbuffer. This unifies the handling with how the generic context and other arguments are handled.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
Open
3 tasks
jakobbotsch
commented
Jan 31, 2025
| inlCurArgInfo->argHasSideEff = (curArgVal->gtFlags & (GTF_ALL_EFFECT & ~GTF_GLOB_REF)) != 0; | ||
| // Retbuffer is very often used directly in a dereference, and this | ||
| // generally makes it profitable to duplicate even when it is complex. | ||
| argInfo->argDuplicateComplex = true; |
There was a problem hiding this comment.
This just minimizes some regressions, since the old behavior was more aggressive in duplicating the return buffer shape.
|
/azp run Fuzzlyn |
|
Azure Pipelines successfully started running 1 pipeline(s). |
3 tasks
This was referenced Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid directly capturing the return buffer from the call in the inliner; instead record an actual
InlArgInfoentry for the retbuffer. This unifies the handling with how the generic context and other arguments are handled.Fix #112053