Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the failing template test for AVX10.2 #112252

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

khushal1996
Copy link
Contributor

@khushal1996 khushal1996 commented Feb 6, 2025

This PR fixes a bug on main which went in with the AVX10.2 API PR #111209. The instruction tuple type was wrong which led to a wrong processing of inputsizeByte variable during emit. This would lead to a failure of template test for Avx10v2.V512.MultipleSumAbsoluteDifferences
image

Fixes bug that went in with #111209
Debug points here - #111209 (comment)

Testing overview
For this PR, we will only run tests with AVX10.2 enabled for base vs diff

Testing results


Run JIT subtree with AVX10.2 enabled / disabled

Base (main branch)
image
image

13:39:58.691 Running test: _Avx10v2_V512_r::JIT.HardwareIntrinsics.X86._Avx10v2_V512.Program.MultipleSumAbsoluteDifferences64UInt160()                                                                                                                                                                                                                                                                                                                                                                                      
Assert failure(PID 58244 [0x0000e384], Thread: 37524 [0x9294]): Assertion failed 'inputSize == 4 || inputSize == 8' in 'JIT.HardwareIntrinsics.X86._Avx10v2_V512.ImmBinaryOpTest__MultipleSumAbsoluteDifferences64UInt160:RunBasicScenario_UnsafeRead():this' during 'Generate code' (IL size 115; hash 0x5b59c195; MinOpts)                                                                                                                                                                                                                                                                                                                                                                                                                                                                  
File: D:\Git_repos\runtime\src\coreclr\jit\emitxarch.cpp:17722                                                                                                                                                                                                
Image: D:\Git_repos\runtime\artifacts\tests\coreclr\windows.x64.Debug\Tests\Core_Root\corerun.exe                                                                                                                                                                                             

Diff (with changes)
image

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 6, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Feb 6, 2025
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@khushal1996 khushal1996 marked this pull request as ready for review February 7, 2025 01:33
@khushal1996
Copy link
Contributor Author

@tannergooding this PR fixes the failing template test we discussed here. #111209 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants