Skip to content

Deref pointer in minipal/time #114598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 19, 2025
Merged

Deref pointer in minipal/time #114598

merged 3 commits into from
Apr 19, 2025

Conversation

am11
Copy link
Member

@am11 am11 commented Apr 13, 2025 •
edited
Loading

usecsSinceYield -> *usecsSinceYield
and replace one-off HAVE_WINDOWS_H with HOST_WINDOWS.

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 13, 2025
@am11 am11 added area-PAL-coreclr community-contribution Indicates that the PR has been added by a community member and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Apr 13, 2025
This was referenced Apr 13, 2025
Open
Closed
Open
Open
Open
jkotas
jkotas reviewed Apr 17, 2025
View reviewed changes
@jkotas jkotas requested a review from VSadov April 17, 2025 15:51
VSadov
VSadov approved these changes Apr 18, 2025
View reviewed changes
Copy link
Member

@VSadov VSadov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!!

@build-analysis build-analysis bot mentioned this pull request Apr 18, 2025
Closed
@VSadov VSadov merged commit 07f3e33 into dotnet:main Apr 19, 2025
160 of 163 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas left review comments

@VSadov VSadov VSadov approved these changes

@jkoritzinsky jkoritzinsky Awaiting requested review from jkoritzinsky

@janvorli janvorli Awaiting requested review from janvorli

Assignees
No one assigned
Labels
area-PAL-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@am11 @jkotas @VSadov