Skip to content

Add Sve.IsSupported check in test #116026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

Add Sve.IsSupported check in test #116026

merged 1 commit into from
May 28, 2025

Conversation

kunalspathak
Copy link
Member

Fixes: #115988

@Copilot Copilot AI review requested due to automatic review settings May 27, 2025 17:13
@github-actions github-actions bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 27, 2025
@kunalspathak kunalspathak mentioned this pull request May 27, 2025
Closed
Copilot
Copilot AI reviewed May 27, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a safeguard in the SVE tests to only run certain test functions if SVE support is available, addressing issue #115988.

  • Added an if-check for Sve.IsSupported in the test method
  • Wrapped the existing test functionality in a conditional block to avoid execution on unsupported platforms

src/tests/JIT/opt/SVE/PredicateInstructions.cs
Xor();
Or();
ConditionalSelect();
if (Sve.IsSupported)
Copy link
Preview

Copilot AI May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider marking the test as skipped using xUnit's Skip parameter on the [Fact] attribute instead of conditionally branching within the test. This approach would provide clearer test reporting when SVE is not supported.

Copilot uses AI. Check for mistakes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you give an example on how to do it?

@kunalspathak
Copy link
Member Author

@a74nh PTAL

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@kunalspathak
Copy link
Member Author

/azp run runtime-coreclr jitstress-isas-arm

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@filipnavara filipnavara mentioned this pull request May 28, 2025
Merged
@kunalspathak
Copy link
Member Author

@dotnet/jit-contrib

amanasifkhalid
amanasifkhalid approved these changes May 28, 2025
View reviewed changes
Copy link
Member

@amanasifkhalid amanasifkhalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing the jitstress-isas-arm failure is unrelated?

@kunalspathak
Copy link
Member Author

I'm guessing the jitstress-isas-arm failure is unrelated?

Yes, it is related to #116030 which was fixed in #116038.

@kunalspathak
Copy link
Member Author

/ba-g failures are related to #116030.

@kunalspathak kunalspathak merged commit b4d7fca into dotnet:main May 28, 2025
75 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@EgorBo EgorBo EgorBo approved these changes

@amanasifkhalid amanasifkhalid amanasifkhalid approved these changes

Assignees

@kunalspathak kunalspathak

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test failure: JIT/opt/SVE/PredicateInstructions/PredicateInstructions.cmd
3 participants
@kunalspathak @EgorBo @amanasifkhalid