Increase timeouts for native AOT legs #116114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linux helix queues are getting backed up with 100+ minutes delays. 120 minute timeout is not enough.
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
Comment on lines
531
to
+534
| - name: timeoutPerTestCollectionInMinutes | ||
| value: 180 | ||
| jobParameters: | ||
| timeoutInMinutes: 120 | ||
| timeoutInMinutes: 180 |
There was a problem hiding this comment.
[nitpick] Consider extracting the repeated timeout value into a template variable or parameter to avoid duplication and simplify future adjustments.
Copilot uses AI. Check for mistakes.
| @@ -614,7 +614,7 @@ extends: | |||
| value: 180 | |||
| jobParameters: | |||
| testGroup: innerloop | |||
| timeoutInMinutes: 120 | |||
| timeoutInMinutes: 180 | |||
There was a problem hiding this comment.
[nitpick] This timeout value is duplicated; using a shared variable would reduce repetition and make updates easier.
Suggested change
| timeoutInMinutes: 180 | |
| timeoutInMinutes: ${{ variables['timeoutPerTestCollectionInMinutes'] }} |
Copilot uses AI. Check for mistakes.
|
cc @dotnet/runtime-infrastructure |
steveisok
approved these changes
May 29, 2025
This was referenced May 30, 2025
Open
|
/ba-g timeouts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux helix queues are getting backed up with 100+ minutes delays. 120 minute timeout is not enough.