-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[browser] SystemJS_GetLocaleInfo and dependencies #120147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <[email protected]>
some renames
Tagging subscribers to this area: @dotnet/area-system-globalization |
radekdoulik
reviewed
Sep 29, 2025
import { InternalExchangeIndex } from "../types"; | ||
|
||
export { SystemJS_RandomBytes } from "./crypto"; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
export { SystemJS_GetLocaleInfo } from "./globalization-locale"; | |
I solved the problem in #119866 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
arch-wasm
WebAssembly architecture
area-System.Globalization
os-browser
Browser variant of arch-wasm
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #119866
Just 763ab3c and after
This PR brings interesting question of which final JS module should contain string and memory helpers. They will be used mostly with JS interop, so they would belong to
dotnet.runtime.js
from that perspective. But this creates dependency arrow in wrong direction. Fromdotnet.native.js
todotnet.runtime.js
, in the case we wanted to make JS interop optional. Adding them as untrimmable closure todotnet.native.js
would solve it.This is the managed caller
runtime/src/libraries/System.Private.CoreLib/src/System/Globalization/CultureData.Browser.cs
Lines 42 to 50 in f76cbfd
And maybe we don't need
SystemJS_GetLocaleInfo
andJSGetNativeDisplayName
at all @ilonatommy ?cc @maraf