-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Packing Legacy cDAC apis #121081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packing Legacy cDAC apis #121081
Conversation
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the legacy cDAC APIs to support a future private cDAC implementation by:
- Extracting legacy code into a separate package (
Microsoft.Diagnostics.DataContractReader.Legacy) with public visibility - Adding extensibility for custom contract implementations via
additionalFactoriesparameter - Exposing
GetContract<TContract>()publicly to enable access to contracts outside the default registry
Reviewed Changes
Copilot reviewed 23 out of 25 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| mscordaccore_universal.csproj | Updates project reference to point to the new Legacy package and removes obsolete Interop.BOOL.cs reference |
| Entrypoints.cs | Makes entrypoint methods public and passes null for additionalFactories parameter in initialization calls |
| ContractDescriptorTarget.cs | Adds additionalFactories parameter to creation methods and passes it to CachingContractRegistry |
| CachingContractRegistry.cs | Adds logic to register additional contract factories during initialization |
| TypeNameBuilder.cs | Changes visibility to public and fixes ArgumentException constructor call |
| SOSDacImpl.cs | Changes class visibility from internal to public |
| SOSDacImpl.IXCLRDataProcess.cs | Changes class visibility to public and seals EnumMethodInstances class |
| SOSDacImpl.ICLRDataEnumMemoryRegions.cs | Changes class visibility from internal to public |
| OutputBufferHelpers.cs | Changes class visibility from internal to public |
| Microsoft.Diagnostics.DataContractReader.Legacy.csproj | New project file for the Legacy package |
| Interop.BOOL.cs | New file containing BOOL enum previously shared via CommonPath |
| IXCLRData.cs | Changes all interface and struct visibility from internal to public |
| ISOSDacInterface.cs | Changes all interface, struct, and enum visibility from internal to public |
| ICLRData.cs | Changes interface visibility from internal to public |
| ConversionExtensions.cs | Changes class and ToAddress method visibility to public |
| ClrDataTask.cs | Changes class visibility from internal to public |
| ClrDataStackWalk.cs | Changes class visibility from internal to public |
| ClrDataModule.cs | Changes class visibility from internal to public |
| ClrDataMethodInstance.cs | Changes class visibility from internal to public |
| ClrDataFrame.cs | Changes class visibility from internal to public |
| ClrDataAddress.cs | Changes struct and marshaller visibility from internal to public |
| IContractFactory.cs | Adds ContractType property to interface |
| ContractRegistry.cs | Adds abstract GetContract() method |
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/TypeNameBuilder.cs
Outdated
Show resolved
Hide resolved
...ative/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/IContractFactory.cs
Show resolved
Hide resolved
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/TypeNameBuilder.cs
Outdated
Show resolved
Hide resolved
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader/CachingContractRegistry.cs
Show resolved
Hide resolved
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader/ContractDescriptorTarget.cs
Outdated
Show resolved
Hide resolved
…er.Legacy/TypeNameBuilder.cs Co-authored-by: Jeremy Koritzinsky <[email protected]>
…into cdac-private-updates
This PR does some work and refactoring in order to facilitate a private version of the cDAC.