Remove unsafe code from Uri path dot & slash unescaping #121680
+21
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tagging subscribers to this area: @dotnet/ncl |
Copilot finished reviewing on behalf of
MihaZupan
November 16, 2025 05:48
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR successfully removes unsafe code from URI path dot and slash unescaping, eliminating the last remaining use of unsafe from the Uri class. The refactoring replaces a pointer-based implementation with a safe, span-based approach while maintaining equivalent functionality.
Key Changes:
- Replaced the
unsafemethodUnescapeOnlywith a safe methodUnescapePathSlashesAndDots - Removed
unsafemodifier fromGetCanonicalPathmethod - Refactored from pointer arithmetic with goto-based control flow to a cleaner loop-based implementation using Span
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Together with all the other recent PRs, this removes the only remaining use of unsafe from Uri 🎉.
This helper is only used for file Uris where the path wasn't already in a canonical form. Perf is about the same.