Skip to content

Build the test tree with TrimMode=full #121697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
+36 −38
Draft

Build the test tree with TrimMode=full #121697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3d6aa30
Build the test tree with TrimMode=full
MichalStrehovsky Nov 17, 2025
d086a39
Merge branch 'main' into MichalStrehovsky-patch-1
MichalStrehovsky Nov 17, 2025
b24ee67
Add DynamicallyAccessedMembers attributes to variance test helpers (#…
Copilot Nov 18, 2025
67c6b16
Add DynamicallyAccessedMembers attributes to UIsInstT methods in vari…
Copilot Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions src/tests/Directory.Build.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,10 +531,6 @@
<!-- IL projects often have mismatches assembly names vs file names and that breaks Win32 resource generation option -->
<IlcGenerateWin32Resources Condition="'$(Language)' == 'IL'">false</IlcGenerateWin32Resources>

<!-- The default TrimMode in the SDK is full. But trimming most of the tests would just make them fail,
so the default for the test tree is partial. -->
<TrimMode Condition="'$(EnableAggressiveTrimming)' != 'true'">partial</TrimMode>

<IlcTreatWarningsAsErrors>false</IlcTreatWarningsAsErrors>

<IlcToolsPath>$(CoreCLRCrossILCompilerDir)</IlcToolsPath>
Expand All @@ -560,16 +556,6 @@
<!-- Bump the generic cycle tolerance. There's at least one test with a cycle that is reachable at runtime to depth 6 -->
<IlcArg Include="--maxgenericcycle:7" />

<!-- We set TrimMode to partial so that we don't trim parts of the tests,
but don't make this apply to xunit cruft -->
<IlcArg Include="--trim:Microsoft.DotNet.XUnitExtensions" />
<IlcArg Include="--trim:xunit.abstractions" />
<IlcArg Include="--trim:xunit.assert" />
<IlcArg Include="--trim:xunit.console" />
<IlcArg Include="--trim:xunit.core" />
<IlcArg Include="--trim:xunit.execution.dotnet" />
<IlcArg Include="--trim:xunit.abstractions" />

<!-- NativeAOT compiled output is placed into a 'native' subdirectory: we need to set
rpath so that the test can load its native library dependencies if there's any -->
<LinkerArg Include="-Wl,-rpath,'@executable_path/..'" Condition="'$(SetIlcRPath)' != 'false' and ('$(TargetOS)' == 'osx' or '$(TargetsAppleMobile)' == 'true')" />
Expand Down
3 changes: 2 additions & 1 deletion src/tests/Loader/classloader/generics/Variance/IL/IsInst001.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.Diagnostics.CodeAnalysis;
using Xunit;

public class Base {}
Expand Down Expand Up @@ -33,7 +34,7 @@ public static void Eval(string location, bool exp)
}
}

public static bool UIsInstT<T,U>(bool expected)
public static bool UIsInstT<T, [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)] U>(bool expected)
{
try
{
Expand Down
3 changes: 2 additions & 1 deletion src/tests/Loader/classloader/generics/Variance/IL/IsInst002.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.Diagnostics.CodeAnalysis;
using Xunit;

public class Base {}
Expand Down Expand Up @@ -35,7 +36,7 @@ public static void Eval(string location, bool exp)
}
}

public static bool UIsInstT<T,U>(bool expected)
public static bool UIsInstT<T, [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)] U>(bool expected)
{
try
{
Expand Down
3 changes: 2 additions & 1 deletion src/tests/Loader/classloader/generics/Variance/IL/IsInst003.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.Diagnostics.CodeAnalysis;
using Xunit;

public class Base {}
Expand Down Expand Up @@ -33,7 +34,7 @@ public static void Eval(string location, bool exp)
}
}

public static bool UIsInstT<T,U>(bool expected)
public static bool UIsInstT<T, [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)] U>(bool expected)
{
try
{
Expand Down
3 changes: 2 additions & 1 deletion src/tests/Loader/classloader/generics/Variance/IL/IsInst004.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.Diagnostics.CodeAnalysis;
using Xunit;

public class Base {}
Expand Down Expand Up @@ -33,7 +34,7 @@ public static void Eval(string location, bool exp)
}
}

public static bool UIsInstT<T,U>(bool expected)
public static bool UIsInstT<T, [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)] U>(bool expected)
{
try
{
Expand Down
3 changes: 2 additions & 1 deletion src/tests/Loader/classloader/generics/Variance/IL/IsInst005.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.Diagnostics.CodeAnalysis;
using Xunit;

public class Base {}
Expand Down Expand Up @@ -33,7 +34,7 @@ public static void Eval(string location, bool exp)
}
}

public static bool UIsInstT<T,U>(bool expected)
public static bool UIsInstT<T, [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)] U>(bool expected)
{
try
{
Expand Down
3 changes: 2 additions & 1 deletion src/tests/Loader/classloader/generics/Variance/IL/IsInst006.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.Diagnostics.CodeAnalysis;
using Xunit;

public class Base {}
Expand Down Expand Up @@ -33,7 +34,7 @@ public static void Eval(string location, bool exp)
}
}

public static bool UIsInstT<T,U>(bool expected)
public static bool UIsInstT<T, [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)] U>(bool expected)
{
try
{
Expand Down
7 changes: 4 additions & 3 deletions src/tests/Loader/classloader/generics/Variance/IL/Unbox001.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.Diagnostics.CodeAnalysis;
using Xunit;

public class Base {}
Expand Down Expand Up @@ -32,17 +33,17 @@ public static void Eval(string location, bool exp)
Console.WriteLine("Test Failed at location: {0} @ count {1} ", location, iTestCount);
}
}
private static void UnboxUToTInternal<T,U>()
private static void UnboxUToTInternal<T, [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)] U>()
{
T t = (T) Activator.CreateInstance(typeof(U));
}

private static void CaseClassUToTWrapper<T,U>()
private static void CaseClassUToTWrapper<T, [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)] U>()
{
UnboxUToTInternal<T,U>();
}

public static bool UnboxUToT<T,U>(bool expected)
public static bool UnboxUToT<T, [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)] U>(bool expected)
{
try
{
Expand Down
7 changes: 4 additions & 3 deletions src/tests/Loader/classloader/generics/Variance/IL/Unbox002.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.Diagnostics.CodeAnalysis;
using Xunit;

public class Base {}
Expand Down Expand Up @@ -32,17 +33,17 @@ public static void Eval(string location, bool exp)
Console.WriteLine("Test Failed at location: {0} @ count {1} ", location, iTestCount);
}
}
private static void UnboxUToTInternal<T,U>()
private static void UnboxUToTInternal<T, [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)] U>()
{
T t = (T) Activator.CreateInstance(typeof(U));
}

private static void CaseClassUToTWrapper<T,U>()
private static void CaseClassUToTWrapper<T, [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)] U>()
{
UnboxUToTInternal<T,U>();
}

public static bool UnboxUToT<T,U>(bool expected)
public static bool UnboxUToT<T, [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)] U>(bool expected)
{
try
{
Expand Down
7 changes: 4 additions & 3 deletions src/tests/Loader/classloader/generics/Variance/IL/Unbox003.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.Diagnostics.CodeAnalysis;
using Xunit;

public class Base {}
Expand Down Expand Up @@ -32,17 +33,17 @@ public static void Eval(string location, bool exp)
Console.WriteLine("Test Failed at location: {0} @ count {1} ", location, iTestCount);
}
}
private static void UnboxUToTInternal<T,U>()
private static void UnboxUToTInternal<T, [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)] U>()
{
T t = (T) Activator.CreateInstance(typeof(U));
}

private static void CaseClassUToTWrapper<T,U>()
private static void CaseClassUToTWrapper<T, [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)] U>()
{
UnboxUToTInternal<T,U>();
}

public static bool UnboxUToT<T,U>(bool expected)
public static bool UnboxUToT<T, [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)] U>(bool expected)
{
try
{
Expand Down
7 changes: 4 additions & 3 deletions src/tests/Loader/classloader/generics/Variance/IL/Unbox004.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.Diagnostics.CodeAnalysis;
using Xunit;

public class Base {}
Expand Down Expand Up @@ -32,17 +33,17 @@ public static void Eval(string location, bool exp)
Console.WriteLine("Test Failed at location: {0} @ count {1} ", location, iTestCount);
}
}
private static void UnboxUToTInternal<T,U>()
private static void UnboxUToTInternal<T, [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)] U>()
{
T t = (T) Activator.CreateInstance(typeof(U));
}

private static void CaseClassUToTWrapper<T,U>()
private static void CaseClassUToTWrapper<T, [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)] U>()
{
UnboxUToTInternal<T,U>();
}

public static bool UnboxUToT<T,U>(bool expected)
public static bool UnboxUToT<T, [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)] U>(bool expected)
{
try
{
Expand Down
7 changes: 4 additions & 3 deletions src/tests/Loader/classloader/generics/Variance/IL/Unbox005.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.Diagnostics.CodeAnalysis;
using Xunit;

public class Base {}
Expand Down Expand Up @@ -32,17 +33,17 @@ public static void Eval(string location, bool exp)
Console.WriteLine("Test Failed at location: {0} @ count {1} ", location, iTestCount);
}
}
private static void UnboxUToTInternal<T,U>()
private static void UnboxUToTInternal<T, [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)] U>()
{
T t = (T) Activator.CreateInstance(typeof(U));
}

private static void CaseClassUToTWrapper<T,U>()
private static void CaseClassUToTWrapper<T, [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)] U>()
{
UnboxUToTInternal<T,U>();
}

public static bool UnboxUToT<T,U>(bool expected)
public static bool UnboxUToT<T, [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)] U>(bool expected)
{
try
{
Expand Down
7 changes: 4 additions & 3 deletions src/tests/Loader/classloader/generics/Variance/IL/Unbox006.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.Diagnostics.CodeAnalysis;
using Xunit;

public class Base {}
Expand Down Expand Up @@ -32,17 +33,17 @@ public static void Eval(string location, bool exp)
Console.WriteLine("Test Failed at location: {0} @ count {1} ", location, iTestCount);
}
}
private static void UnboxUToTInternal<T,U>()
private static void UnboxUToTInternal<T, [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)] U>()
{
T t = (T) Activator.CreateInstance(typeof(U));
}

private static void CaseClassUToTWrapper<T,U>()
private static void CaseClassUToTWrapper<T, [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)] U>()
{
UnboxUToTInternal<T,U>();
}

public static bool UnboxUToT<T,U>(bool expected)
public static bool UnboxUToT<T, [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)] U>(bool expected)
{
try
{
Expand Down
Loading