MethodEntrypointOrTentativeMethod should tolerate same entrypoints for different MethodDescs #121703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r different MethodDescs Ran into this as I was trying something with #121456. That PR introduces a situation where two MethodDescs could map to the same EntryPoint. We didn't previously have that since MethodEntrypointOrTentativeMethod doesn't support unboxing thunks (that do a similar trick).
Contributor
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
Copilot finished reviewing on behalf of
MichalStrehovsky
November 17, 2025 10:03
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the NodeFactory to support scenarios where multiple MethodDesc instances can map to the same entrypoint. The key change is converting the _tentativeMethods cache from being keyed by MethodDesc to being keyed by IMethodBodyNode (the actual entrypoint), ensuring a 1:1 relationship between TentativeInstanceMethodNode instances and entrypoints.
- Changes the cache key for tentative methods from
MethodDesctoIMethodBodyNode - Ensures that when different MethodDescs share the same entrypoint, they also share the same
TentativeInstanceMethodNode - Prevents issues that could arise from having multiple
TentativeInstanceMethodNodeinstances pointing to the same entrypoint
jkotas
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into this as I was trying something with #121456. That PR introduces a situation where two MethodDescs could map to the same EntryPoint. We didn't previously have that since MethodEntrypointOrTentativeMethod doesn't support unboxing thunks (that do a similar trick).
Without this fix we would end up with two
TentativeInstanceMethodNodethat point to the same EntryPoint and that doesn't lead to anything good. These need to be 1:1 with entrypoints.Cc @dotnet/ilc-contrib