Arm64: [SVE] Fix failing NaN comparisons in Sve2.ConvertTo* tests #121706
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
Member
|
@SwapnilGaikwad do you need to run |
EgorBo
approved these changes
Nov 17, 2025
SwapnilGaikwad
changed the title
Contributor
Author
It would be useful, cheers. However, the other |
Member
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
@SwapnilGaikwad it looks like this change introduced a lot more new failures from 40-50 to 800+ |
Contributor
Author
Apologies. Now limited the changes to only ConvertTo* tests using separate templates. Let's see how this goes, didn't show any failures locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribute towards #121659
This PR fixes the NaN comparisons that were incorrectly handled in ConvertTo* tests as highlighted in the following screenshot.
Failure output.
@dotnet/arm64-contrib @a74nh @EgorBo