Add explicit default constructors in Variance/IL tests for TrimMode=full #121731
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests in
src/tests/Loader/classloader/generics/Variance/ILuseActivator.CreateInstance(typeof(U))to instantiate generic types at runtime. With TrimMode=full, the trimmer removes implicit default constructors, causing test failures.Changes
Added explicit default constructors to generic class types in 14 test files in
src/tests/Loader/classloader/generics/Variance/IL/:GBase<T>,GSubT<T>,GTU<T,U>,GTArrUArr<T,U>,GRefTRefU<T,U>,GRefTArrRefUArr<T,U>,GArrRefTArrRefU<T,U>Example change:
By explicitly defining default constructors in the source code, the trimmer recognizes them as used members and preserves them, allowing
Activator.CreateInstance()to work correctly at runtime. Struct types were not modified as they always have a default constructor in C#.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.