Fix additional issue to support >1024 CPUs#127572
Merged
janvorli merged 2 commits intoMay 13, 2026
Merged
Conversation
In my previous PR I have missed one case when we only set the affinity. This change fixes it.
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @dotnet/gc |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CoreCLR GC Unix OS abstraction to fully support machines with more than CPU_SETSIZE (typically 1024) logical CPUs when setting thread affinity, addressing a missed case from a prior change.
Changes:
- Cache the OS “configured CPU count” during
GCToOSInterface::Initialize()for later use. - Update
GCToOSInterface::SetThreadAffinity()to use dynamically allocated CPU sets (CPU_ALLOC/CPU_*_S) instead of a fixed-sizecpu_set_t.
jkotas
approved these changes
Apr 29, 2026
Member
|
@VSadov for review |
This was referenced Apr 30, 2026
Open
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates CoreCLR GC’s Unix environment layer to correctly set per-thread CPU affinity on systems with more than CPU_SETSIZE (typically 1024) logical CPUs, addressing a previously missed code path that still used a fixed-size cpu_set_t.
Changes:
- Cache the OS configured CPU count (
g_configuredCpuCount) duringGCToOSInterface::Initialize(). - Switch
GCToOSInterface::SetThreadAffinityto use dynamically allocated CPU sets (CPU_ALLOC*+*_Smacros) and free them after applying affinity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my previous PR I have missed one case when we only set the affinity. This change fixes it.