Skip to content

Remove DacDbi GetAppDomainObject API from native and cDAC #127673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barosiak merged 3 commits into from
May 2, 2026
Merged

Remove DacDbi GetAppDomainObject API from native and cDAC #127673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
17aade7
Remove DacDbi GetAppDomainObject API from native and cDAC
barosiak May 1, 2026
816b9bb
Remove GetRawExposedObject method from appdomain.hpp
rcj1 May 1, 2026
9235c69
Update a comment
barosiak May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions src/coreclr/debug/daccess/dacdbiimpl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,26 +664,6 @@ HRESULT STDMETHODCALLTYPE DacDbiInterfaceImpl::GetAppDomainId(VMPTR_AppDomain vm
return hr;
}

// Get the managed AppDomain object for an AppDomain.
HRESULT STDMETHODCALLTYPE DacDbiInterfaceImpl::GetAppDomainObject(VMPTR_AppDomain vmAppDomain, OUT VMPTR_OBJECTHANDLE * pRetVal)
{
DD_ENTER_MAY_THROW;

HRESULT hr = S_OK;
EX_TRY
{

AppDomain* pAppDomain = vmAppDomain.GetDacPtr();
OBJECTHANDLE hAppDomainManagedObject = pAppDomain->GetRawExposedObjectHandleForDebugger();
VMPTR_OBJECTHANDLE vmObj = VMPTR_OBJECTHANDLE::NullPtr();
vmObj.SetDacTargetPtr(hAppDomainManagedObject);
*pRetVal = vmObj;

}
EX_CATCH_HRESULT(hr);
return hr;
}

// Get the full AD friendly name for the given EE AppDomain.
HRESULT STDMETHODCALLTYPE DacDbiInterfaceImpl::GetAppDomainFullName(VMPTR_AppDomain vmAppDomain, IStringHolder * pStrName)
{
Expand Down
3 changes: 0 additions & 3 deletions src/coreclr/debug/daccess/dacdbiimpl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,6 @@ class DacDbiInterfaceImpl :
// Get the AppDomain ID for an AppDomain.
HRESULT STDMETHODCALLTYPE GetAppDomainId(VMPTR_AppDomain vmAppDomain, OUT ULONG * pRetVal);

// Get the managed AppDomain object for an AppDomain.
HRESULT STDMETHODCALLTYPE GetAppDomainObject(VMPTR_AppDomain vmAppDomain, OUT VMPTR_OBJECTHANDLE * pRetVal);

// Get the full AD friendly name for the appdomain.
HRESULT STDMETHODCALLTYPE GetAppDomainFullName(VMPTR_AppDomain vmAppDomain, IStringHolder * pStrName);

Expand Down
21 changes: 4 additions & 17 deletions src/coreclr/debug/di/rsappdomain.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,8 +702,8 @@ HRESULT CordbAppDomain::GetName(ULONG32 cchName,
}

/*
* GetObject returns the runtime app domain object.
* Note: this is lazily initialized and may be NULL
* GetObject always returns S_FALSE with a null object.
* The runtime AppDomain object is not available through this API.
*/
HRESULT CordbAppDomain::GetObject(ICorDebugValue **ppObject)
{
Expand All @@ -714,24 +714,11 @@ HRESULT CordbAppDomain::GetObject(ICorDebugValue **ppObject)
ATT_REQUIRE_STOPPED_MAY_FAIL(GetProcess());

_ASSERTE(!m_vmAppDomain.IsNull());
IDacDbiInterface * pDac = NULL;
HRESULT hr = S_OK;
EX_TRY
{
pDac = m_pProcess->GetDAC();
VMPTR_OBJECTHANDLE vmObjHandle;
IfFailThrow(pDac->GetAppDomainObject(m_vmAppDomain, &vmObjHandle));
if (!vmObjHandle.IsNull())
{
ICorDebugReferenceValue * pRefValue = NULL;
hr = CordbReferenceValue::BuildFromGCHandle(this, vmObjHandle, &pRefValue);
*ppObject = pRefValue;
}
else
{
*ppObject = NULL;
hr = S_FALSE;
}
*ppObject = NULL;
hr = S_FALSE;
Comment thread
barosiak marked this conversation as resolved.
}
EX_CATCH_HRESULT(hr);

Expand Down
17 changes: 0 additions & 17 deletions src/coreclr/debug/inc/dacdbiinterface.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,23 +265,6 @@ IDacDbiInterface : public IUnknown
//
virtual HRESULT STDMETHODCALLTYPE GetAppDomainId(VMPTR_AppDomain vmAppDomain, OUT ULONG * pRetVal) = 0;

//
// Get the managed AppDomain object for an AppDomain.
//
// Arguments:
// vmAppDomain - VM pointer to the AppDomain object of interest
// pRetVal - [out] Objecthandle for the managed app domain object or the Null VMPTR if there is no object created yet.
//
// Return Value:
// S_OK on success; otherwise, an appropriate failure HRESULT.
//
// Notes:
// The AppDomain managed object is lazily constructed on the AppDomain the first time
// it is requested. It may be NULL.
//
virtual HRESULT STDMETHODCALLTYPE GetAppDomainObject(VMPTR_AppDomain vmAppDomain, OUT VMPTR_OBJECTHANDLE * pRetVal) = 0;


//
// Get the full AD friendly name for the given EE AppDomain.
//
Expand Down
1 change: 0 additions & 1 deletion src/coreclr/inc/dacdbi.idl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,6 @@ interface IDacDbiInterface : IUnknown

// App Domains
HRESULT GetAppDomainId([in] VMPTR_AppDomain vmAppDomain, [out] ULONG * pRetVal);
HRESULT GetAppDomainObject([in] VMPTR_AppDomain vmAppDomain, [out] VMPTR_OBJECTHANDLE * pRetVal);
HRESULT GetAppDomainFullName([in] VMPTR_AppDomain vmAppDomain, [in] IDacDbiStringHolder pStrName);
HRESULT GetModuleSimpleName([in] VMPTR_Module vmModule, [in] IDacDbiStringHolder pStrFilename);
Comment thread
rcj1 marked this conversation as resolved.
Comment thread
barosiak marked this conversation as resolved.
HRESULT GetAssemblyPath([in] VMPTR_Assembly vmAssembly, [in] IDacDbiStringHolder pStrFilename, [out] BOOL * pResult);
Expand Down
3 changes: 0 additions & 3 deletions src/coreclr/vm/appdomain.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,9 +675,6 @@ class AppDomain final
STRINGREF *IsStringInterned(STRINGREF *pString);
STRINGREF *GetOrInternString(STRINGREF *pString);

OBJECTREF GetRawExposedObject() { LIMITED_METHOD_CONTRACT; return NULL; }
OBJECTHANDLE GetRawExposedObjectHandleForDebugger() { LIMITED_METHOD_DAC_CONTRACT; return (OBJECTHANDLE)NULL; }

#ifndef DACCESS_COMPILE
PTR_NativeImage GetNativeImage(LPCUTF8 compositeFileName);
PTR_NativeImage SetNativeImage(LPCUTF8 compositeFileName, PTR_NativeImage pNativeImage);
Expand Down
3 changes: 0 additions & 3 deletions src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,6 @@ public int GetAppDomainId(ulong vmAppDomain, uint* pRetVal)
return hr;
}

public int GetAppDomainObject(ulong vmAppDomain, ulong* pRetVal)
=> LegacyFallbackHelper.CanFallback() && _legacy is not null ? _legacy.GetAppDomainObject(vmAppDomain, pRetVal) : HResults.E_NOTIMPL;

public int GetAppDomainFullName(ulong vmAppDomain, nint pStrName)
{
int hr = HResults.S_OK;
Expand Down
3 changes: 0 additions & 3 deletions ...tive/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,9 +166,6 @@ public unsafe partial interface IDacDbiInterface
[PreserveSig]
int GetAppDomainId(ulong vmAppDomain, uint* pRetVal);

[PreserveSig]
int GetAppDomainObject(ulong vmAppDomain, ulong* pRetVal);

[PreserveSig]
int GetAppDomainFullName(ulong vmAppDomain, nint pStrName);

Expand Down
Loading