Skip to content

Handle minimal MethodTables in dotnet-pgo trace processing #127818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DrewScoggins merged 3 commits into from
May 22, 2026
+12 −1
Merged

Handle minimal MethodTables in dotnet-pgo trace processing #127818

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d135fa
Handle minimal MethodTables in dotnet-pgo trace processing
DrewScoggins May 5, 2026
fe452d2
Warn on out-of-range TypeDef rid instead of silently ignoring
DrewScoggins May 20, 2026
b33775c
Remove out-of-range rid guard; let GetType throw naturally
DrewScoggins May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/coreclr/tools/dotnet-pgo/TraceRuntimeDescToTypeSystemDesc.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,18 @@ public TypeDesc ResolveTypeHandle(long handle, ref bool dependsOnKnownNonLoadabl
throw new Exception($"Invalid typedef {tinfo.TypeValue.TypeNameID:4x}");
}

TypeDefinitionHandle typedef = MetadataTokens.TypeDefinitionHandle(tinfo.TypeValue.TypeNameID & 0xFFFFFF);
int typedefRow = tinfo.TypeValue.TypeNameID & 0xFFFFFF;
// The runtime emits BulkType events for "minimal" MethodTables created by
// CreateMinimalMethodTable in coreclr (used for Reflection.Emit DynamicMethod
// hosts and the IL stub cache). These MTs have no typedef token and surface
// here as TypeNameID == 0x02000000 (rid 0). Treat them as unresolvable
// dynamic types so trace processing can continue.
if (typedefRow == 0)
{
dependsOnKnownNonLoadableType = true;
return null;
}
Comment thread
DrewScoggins marked this conversation as resolved.
TypeDefinitionHandle typedef = MetadataTokens.TypeDefinitionHandle(typedefRow);
MetadataType uninstantiatedType = (MetadataType)ecmaModule.GetType(typedef);
// Instantiate the type if requested
if ((tinfo.TypeValue.TypeParameters.Length != 0) && uninstantiatedType != null)
Expand Down
Loading