Skip to content

Set per-target compile PDB for cDAC descriptor object libraries #127836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steveisok merged 3 commits into from
May 6, 2026
+13 −1
Merged

Set per-target compile PDB for cDAC descriptor object libraries #127836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d94d8d
Set per-target compile PDB for cDAC descriptor object libraries
lewing May 5, 2026
04a3e0e
Make descriptor PDB path config-specific for multi-config generators
lewing May 5, 2026
d649563
Fix GCC sign-compare error in emitOutputULEB128Padded
steveisok May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/coreclr/clrdatadescriptors.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,4 +88,16 @@ function(generate_data_descriptors)
# Set include directories for the data descriptor targets, now that they are created.
target_include_directories(${LIBRARY} PUBLIC ${DATA_DESCRIPTOR_SHARED_INCLUDE_DIR})
target_include_directories(${LIBRARY} PRIVATE ${GENERATED_CDAC_DESCRIPTOR_DIR})

if(MSVC)
# Give this OBJECT library a deterministic, per-target compile PDB. Without this,
# MSVC writes debug info to the default `vc140.pdb`, which does not travel with
# the .obj files when they are archived into a static library (e.g.
# Runtime.ServerGC.lib). Downstream linkers - notably the NativeAOT publish
# of ILCompiler/crossgen2/ilasm - then emit LNK4099 ("PDB 'vc140.pdb' was not
# found"), which is fatal under /WX.
set_target_properties(${LIBRARY} PROPERTIES
COMPILE_PDB_NAME "${LIBRARY}"
COMPILE_PDB_OUTPUT_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}/$<CONFIG>")
endif()
endfunction(generate_data_descriptors)
2 changes: 1 addition & 1 deletion src/coreclr/jit/emitwasm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,7 @@ size_t emitter::emitOutputULEB128(uint8_t* destination, uint64_t value)
size_t emitter::emitOutputULEB128Padded(uint8_t* destination, uint64_t value)
{
uint8_t* buffer = destination + writeableOffset;
int i = 0;
unsigned i = 0;

Comment thread
steveisok marked this conversation as resolved.
for (; i < PADDED_RELOC_SIZE - 1; i++)
{
Expand Down
Loading