No-op: emitwasm.cpp sign-compare warning already fixed on main#127874
Closed
No-op: emitwasm.cpp sign-compare warning already fixed on main#127874
Conversation
Copilot
AI
changed the title
[WIP] Fix comparison of integer expressions of different signedness
No-op: emitwasm.cpp sign-compare warning already fixed on main
May 6, 2026
github-actions
Bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Build 1409473 failed with
-Werror=sign-compareinemitOutputULEB128Padded:The loop variable
iwasintwhilePADDED_RELOC_SIZEisstatic const unsigned.Changes
1f84bc933968(PR Set per-target compile PDB for cDAC descriptor object libraries #127836, May 5 2026) already changed line 602 fromint i = 0;tounsigned i = 0;, which silences the warning. The failing build predates that commit.Verified by reproducing the diagnostic in isolation under
g++ -Wsign-compare -Werror: the priorint iform errors, the currentunsigned iform compiles cleanly.The referenced issue can be closed as already resolved.