Skip to content

Remove some dead code from impAppendStmt and impStoreStruct #128033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tannergooding merged 2 commits into from
May 12, 2026
+3 −18
Merged

Remove some dead code from impAppendStmt and impStoreStruct #128033

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d57a2d
Remove some dead code from impAppendStmt and impStoreStruct
tannergooding May 11, 2026
12890c3
Merge branch 'main' into remove-dead-code
tannergooding May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 3 additions & 18 deletions src/coreclr/jit/importer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,17 +391,8 @@ void Compiler::impAppendStmt(Statement* stmt, unsigned chkLevel, bool checkConsu

if (call->TypeIs(TYP_VOID) && call->AsCall()->ShouldHaveRetBufArg())
{
GenTree* retBuf;
if (call->AsCall()->ShouldHaveRetBufArg())
{
assert(call->AsCall()->gtArgs.HasRetBuffer());
retBuf = call->AsCall()->gtArgs.GetRetBufferArg()->GetNode();
}
else
{
assert(!call->AsCall()->gtArgs.HasThisPointer());
retBuf = call->AsCall()->gtArgs.GetArgByIndex(0)->GetNode();
}
assert(call->AsCall()->gtArgs.HasRetBuffer());
GenTree* retBuf = call->AsCall()->gtArgs.GetRetBufferArg()->GetNode();

assert(retBuf->TypeIs(TYP_I_IMPL, TYP_BYREF));

Expand Down Expand Up @@ -798,12 +789,6 @@ GenTree* Compiler::impStoreStruct(GenTree* store,
if (srcCall->ShouldHaveRetBufArg())
{
// Case of call returning a struct via hidden retbuf arg.
// Some calls have an "out buffer" that is not actually a ret buff
// in the ABI sense. We take the path here for those but it should
// not be marked as the ret buff arg since it always follow the
// normal ABI for parameters.
WellKnownArg wellKnownArgType =
srcCall->ShouldHaveRetBufArg() ? WellKnownArg::RetBuffer : WellKnownArg::None;

GenTreeFlags indirFlags = GTF_EMPTY;
GenTree* destAddr = impGetNodeAddr(store, CHECK_SPILL_ALL, GTF_IND_MUST_PRESERVE_FLAGS, &indirFlags);
Expand All @@ -823,7 +808,7 @@ GenTree* Compiler::impStoreStruct(GenTree* store,
return impStoreStruct(store, curLevel, pAfterStmt, di, block);
}

NewCallArg newArg = NewCallArg::Primitive(destAddr).WellKnown(wellKnownArgType);
NewCallArg newArg = NewCallArg::Primitive(destAddr).WellKnown(WellKnownArg::RetBuffer);

if (destAddr->OperIs(GT_LCL_ADDR))
{
Expand Down
Loading