Skip to content

Exclude badendfinally from Mono MiniFullAOT build to avoid missing AOT module crash#128137

Merged
kotlarmilos merged 4 commits into
mainfrom
copilot/fix-badendfinally-aot-module-loading
May 14, 2026
Merged

Exclude badendfinally from Mono MiniFullAOT build to avoid missing AOT module crash#128137
kotlarmilos merged 4 commits into
mainfrom
copilot/fix-badendfinally-aot-module-loading

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 13, 2026 •
edited
Loading

MiniFullAOT runs were aborting in aot-only mode because JIT/Directed/coverage/importer/badendfinally was scheduled without a generated badendfinally.dll.so. This change applies the existing AOT-incompatible test pattern so the project is not built for Mono minifullaot.

  • Change

    • Updated /src/tests/JIT/Directed/coverage/importer/badendfinally.ilproj to disable project build when:
      • RuntimeFlavor == mono
      • RuntimeVariant == minifullaot

  • Effect

    • Prevents badendfinally.dll from being included in MiniFullAOT payloads where its .so is absent, avoiding the Failed to load AOT module ... in aot-only mode abort path.

  • Implementation

    <PropertyGroup>
  <MonoAotIncompatible>true</MonoAotIncompatible>
  <DisableProjectBuild Condition="'$(RuntimeFlavor)' == 'mono' and '$(RuntimeVariant)' == 'minifullaot'">true</DisableProjectBuild>
</PropertyGroup>

Copilot AI requested review from Copilot and removed request for Copilot May 13, 2026 12:32
Copilot AI linked an issue May 13, 2026 that may be closed by this pull request
[ci-scan] MiniFullAOT: badendfinally Failed to load AOT module in aot-only mode (linux-x64) #127830
Closed
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

dotnet-policy-service Bot commented May 13, 2026

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@kotlarmilos
Disable badendfinally for Mono MiniFullAOT test build
4dbe622 
Co-authored-by: kotlarmilos <11523312+kotlarmilos@users.noreply.github.com>
Copilot AI requested review from Copilot and removed request for Copilot May 13, 2026 12:38
Copilot AI changed the title [WIP] Fix badendfinally AOT module loading issue in linux-x64 Exclude badendfinally from Mono MiniFullAOT build to avoid missing AOT module crash May 13, 2026
Copilot AI requested a review from kotlarmilos May 13, 2026 12:39
@kotlarmilos
Copy link
Copy Markdown
Member

kotlarmilos commented May 13, 2026

@copilot add tracking issue as a comment

@kotlarmilos kotlarmilos marked this pull request as ready for review May 13, 2026 12:46
Copilot AI review requested due to automatic review settings May 13, 2026 12:46
Copilot AI reviewed May 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@kotlarmilos
Add tracking issue comment for badendfinally MiniFullAOT exclusion
0a7f60d 
Co-authored-by: kotlarmilos <11523312+kotlarmilos@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 13, 2026

@copilot add tracking issue as a comment

Added the tracking issue annotation in badendfinally.ilproj on the DisableProjectBuild line: #113060. Addressed in commit 0a7f60d8.

BrzVlad
BrzVlad reviewed May 13, 2026
View reviewed changes
Comment thread src/tests/JIT/Directed/coverage/importer/badendfinally.ilproj Outdated
kotlarmilos
kotlarmilos reviewed May 13, 2026
View reviewed changes
Comment thread src/tests/JIT/Directed/coverage/importer/badendfinally.ilproj Outdated
Copilot AI review requested due to automatic review settings May 13, 2026 15:14
Copilot AI reviewed May 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

This was referenced May 13, 2026
Open
Open
Open
@kotlarmilos kotlarmilos merged commit e5f3415 into main May 14, 2026
84 of 87 checks passed
@kotlarmilos kotlarmilos deleted the copilot/fix-badendfinally-aot-module-loading branch May 14, 2026 08:53
@dotnet-maestro dotnet-maestro Bot mentioned this pull request May 15, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kotlarmilos kotlarmilos kotlarmilos left review comments

Copilot code review Copilot Copilot left review comments

@BrzVlad BrzVlad BrzVlad approved these changes

@steveisok steveisok Awaiting requested review from steveisok

@vitek-karas vitek-karas Awaiting requested review from vitek-karas

@matouskozak matouskozak Awaiting requested review from matouskozak

Assignees

@kotlarmilos kotlarmilos

Copilot code review Copilot

Labels

area-Infrastructure

Projects

Runtime Infra
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ci-scan] MiniFullAOT: badendfinally Failed to load AOT module in aot-only mode (linux-x64)

4 participants

@kotlarmilos @BrzVlad