Skip to content

[ci-scan] Skip StartDetached_GrandchildSurvivesSignalingParent on Windows (refs #126936)#128139

Merged
adamsitnik merged 2 commits into
mainfrom
ci-scan/skip-startdetached-126936-c341e82ae78126d1
May 15, 2026
Merged

[ci-scan] Skip StartDetached_GrandchildSurvivesSignalingParent on Windows (refs #126936)#128139
adamsitnik merged 2 commits into
mainfrom
ci-scan/skip-startdetached-126936-c341e82ae78126d1

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented May 13, 2026

Reasoning

The test System.Diagnostics.Tests.ProcessTests.StartDetached_GrandchildSurvivesSignalingParent(enable: False) has been flaking consistently on Windows in the runtime-extra-platforms pipeline. KBE #126936 confirms 23 hits in the past month and 5 in the past 7 days. The test is assigned to @adamsitnik for investigation. Adding [ActiveIssue] on TestPlatforms.Windows to unblock CI while the root cause is addressed.

The chosen attribute is scoped to Windows only, matching the observed failure scope.

KBE verification:

  1. Same test: Yes - StartDetached_GrandchildSurvivesSignalingParent(enable: False)
  2. Same failure signature: Yes - Assert.Equal() Failure: Values differ
  3. Same OS: Yes - Windows
  4. Same architecture: Yes - x64

Impact on platforms

  • runtime-extra-platforms / windows-x64 Release Libraries_Release_CoreCLR / Windows.10.Amd64.Open / exit code 1

Errors log

System.Diagnostics.Tests.ProcessTests.StartDetached_GrandchildSurvivesSignalingParent(enable: False) [FAIL]
  Assert.Equal() Failure: Values differ
  Expected: False
  Actual:   True

First build it occurred

KBE #126936 was filed 2026-04-15; Build Analysis shows continuous matches since then (23 hits in 1 month). This is within the scanned window and may not be the true origin.

Linked issue

Linked KBE: #126936

Note

🔒 Integrity filter blocked 1 item

The following item was blocked because it doesn't meet the GitHub integrity level.

  • #125825 search_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".

To allow these resources, lower min-integrity in your GitHub frontmatter:

tools:
  github:
    min-integrity: approved  # merged | approved | unapproved | none

Generated by CI Outer-Loop Failure Scanner · ● 37.5M ·

…126936)

The test flakes consistently on Windows in runtime-extra-platforms.
Add [ActiveIssue] to skip it on Windows until the root cause is fixed.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-diagnostics-process
See info in area-owners.md if you want to be subscribed.

@kotlarmilos kotlarmilos marked this pull request as ready for review May 13, 2026 15:18
Copilot AI review requested due to automatic review settings May 13, 2026 15:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR temporarily disables a flaky System.Diagnostics.Process test on Windows by marking the affected theory with an [ActiveIssue] attribute, preventing it from running on Windows CI while the underlying issue is investigated.

Changes:

  • Added [ActiveIssue(..., TestPlatforms.Windows)] to StartDetached_GrandchildSurvivesSignalingParent(...) to skip it on Windows.
Show a summary per file
File Description
src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs Skips StartDetached_GrandchildSurvivesSignalingParent on Windows via [ActiveIssue] to mitigate CI flakiness.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment thread src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs
@kotlarmilos kotlarmilos requested a review from adamsitnik May 15, 2026 11:13
@kotlarmilos kotlarmilos added this to the 11.0.0 milestone May 15, 2026
@kotlarmilos
Copy link
Copy Markdown
Member

@adamsitnik According to the issue, the test is still failing? Do we know what are the next steps or should we disable it and keep the tracking issue?

Copy link
Copy Markdown
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for disabling the test @kotlarmilos !

@adamsitnik adamsitnik enabled auto-merge (squash) May 15, 2026 12:01
@adamsitnik
Copy link
Copy Markdown
Member

/ba-g bad exit is unrelated

@adamsitnik adamsitnik merged commit 6e21c93 into main May 15, 2026
100 of 103 checks passed
@adamsitnik adamsitnik deleted the ci-scan/skip-startdetached-126936-c341e82ae78126d1 branch May 15, 2026 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants