Skip to content

await output and error tasks concurrently via Task.WhenAll #128150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NeverMorewd wants to merge 1 commit into from
+1 −2
Closed

await output and error tasks concurrently via Task.WhenAll #128150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.Multiplexing.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,8 +562,7 @@ public async IAsyncEnumerable<ProcessOutputLine> ReadAllLinesAsync([EnumeratorCa

// Ensure both tasks complete before disposing the CancellationTokenSource.
// The tasks handle all exceptions internally, so they always run to completion.
await outputTask.ConfigureAwait(false);
await errorTask.ConfigureAwait(false);
await Task.WhenAll(outputTask, errorTask).ConfigureAwait(false);

linkedCts.Dispose();
}
Expand Down
Loading