Disable MonoAotIncompatible tests for Mono MiniFullAOT#128184
Closed
Copilot wants to merge 2 commits into
Closed
Conversation
Add DisableProjectBuild condition for RuntimeFlavor==mono and RuntimeVariant==minifullaot to all MonoAotIncompatible test projects that are included in failing MiniFullAOT CI work items (Methodical_d2, Methodical_r1, Methodical_r2, Regression_1, Regression_2, Regression_o_2, jit64_5). Fixes: https://github.com/dotnet/runtime/issues/XXXXXX Co-authored-by: kotlarmilos <11523312+kotlarmilos@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix known build error in MiniFullAot RuntimeTests
Disable MonoAotIncompatible tests for Mono MiniFullAOT
May 14, 2026
github-actions
Bot
added
the
area-Infrastructure-coreclr
3 tasks
kotlarmilos
added a commit
that referenced
this pull request
May 18, 2026
…128188) ## Background Mono in `--full-aot` mode fatally aborts when it encounters a DLL with no AOT module (no `.dll.so` companion). Tests marked `MonoAotIncompatible=true` are correctly skipped during AOT compile (via the existing `.NoMonoAot` marker file mechanism in `src/tests/Directory.Build.targets` and `src/tests/build.proj`), but the DLLs are still bundled into the Helix payload for the minifullaot / llvmfullaot variants — so when mono tries to load them, the work item aborts. Issue #128142 tracks the recurrence. PR #128184 addresses it by adding `<DisableProjectBuild Condition="...minifullaot...">true</DisableProjectBuild>` to 39 individual `.ilproj` files, following the existing pattern in 4 other files. ## Change Move the rule from per-project boilerplate to one central location in `src/tests/Directory.Build.targets`: ```xml <DisableProjectBuild Condition="'$(MonoAotIncompatible)' == 'true' and '$(RuntimeFlavor)' == 'mono' and ('$(RuntimeVariant)' == 'minifullaot' or '$(RuntimeVariant)' == 'llvmfullaot')">true</DisableProjectBuild> ``` Removes the now-redundant per-project lines from the 4 files that already had them. Fixes #128142. Closes/supersedes #128184. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MonoAotIncompatibletest DLLs were being bundled into the MiniFullAOT Helix payload without corresponding.dll.sofiles. Mono in--full-aotmode fatally aborts when it encounters a DLL with no AOT module, causing 13+ work item failures acrossMethodical_d2,Methodical_r1,Methodical_r2,Regression_1,Regression_2,Regression_o_2, andjit64_5.Added
DisableProjectBuildconditioned onmono+minifullaotto 39.ilprojfiles that hadMonoAotIncompatible=truebut were missing the exclusion — following the same pattern already used intest76531.csprojandbadendfinally.ilproj:Affected areas (39 files):
src/tests/JIT/jit64/— 3 files (eh07_large,call05_dynamic,ver_fg_13)src/tests/JIT/Methodical/— 30 files (tailcall, Invoke/SEH, VT/callconv, Boxing, ELEMENT_TYPE_IU, eh/deadcode, flowgraph)src/tests/JIT/Regression/— 4 files (CLR-x86-JIT, JitBlue/Runtime_80731, Dev11)src/tests/Regressions/coreclr/— 2 files