Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -268,22 +268,28 @@ public async Task DnsGetHostAddresses_LocalhostSubdomain_RespectsAddressFamily(A
}

string hostName = "test.localhost";
bool strictAddressFamily = !PlatformDetection.IsAppleMobile && !PlatformDetection.IsAndroid;

// The subdomain goes to OS resolver first. If it fails, it falls back to
// resolving plain "localhost" with the same address family filter.
IPAddress[] addresses = Dns.GetHostAddresses(hostName, addressFamily);
if (addressFamily == AddressFamily.InterNetwork)
{
Assert.True(addresses.Length >= 1, "Expected at least one IPv4 address");
}
Assert.All(addresses, addr => Assert.Equal(addressFamily, addr.AddressFamily));
VerifyAddressFamily(addresses, addressFamily, strictAddressFamily);

addresses = await Dns.GetHostAddressesAsync(hostName, addressFamily);
if (addressFamily == AddressFamily.InterNetwork)
VerifyAddressFamily(addresses, addressFamily, strictAddressFamily);

static void VerifyAddressFamily(IPAddress[] addresses, AddressFamily addressFamily, bool strictAddressFamily)
{
Assert.True(addresses.Length >= 1, "Expected at least one IPv4 address");
if (addressFamily == AddressFamily.InterNetwork)
{
Assert.Contains(addresses, addr => addr.AddressFamily == addressFamily);
}

if (strictAddressFamily)
{
Assert.All(addresses, addr => Assert.Equal(addressFamily, addr.AddressFamily));
}
}
Assert.All(addresses, addr => Assert.Equal(addressFamily, addr.AddressFamily));
}

// RFC 6761: Verify that localhost subdomains return loopback addresses.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -434,21 +434,31 @@ public async Task DnsGetHostEntry_LocalhostSubdomain_RespectsAddressFamily(Addre

string hostName = "test.localhost";

// On Android and Apple mobile the OS resolver may return addresses of a different
// family than requested (e.g. link-local IPv6 results for an IPv4 query), so we
// only require the requested family to be represented in the results there.
bool strictAddressFamily = !PlatformDetection.IsAppleMobile && !PlatformDetection.IsAndroid;

// The subdomain goes to OS resolver first. If it fails, it falls back to
// resolving plain "localhost" with the same address family filter.
IPHostEntry entry = Dns.GetHostEntry(hostName, addressFamily);
if (addressFamily == AddressFamily.InterNetwork)
{
Assert.True(entry.AddressList.Length >= 1, "Expected at least one IPv4 address");
}
Assert.All(entry.AddressList, addr => Assert.Equal(addressFamily, addr.AddressFamily));
VerifyAddressFamily(entry, addressFamily, strictAddressFamily);

entry = await Dns.GetHostEntryAsync(hostName, addressFamily);
if (addressFamily == AddressFamily.InterNetwork)
VerifyAddressFamily(entry, addressFamily, strictAddressFamily);

static void VerifyAddressFamily(IPHostEntry entry, AddressFamily addressFamily, bool strictAddressFamily)
{
Assert.True(entry.AddressList.Length >= 1, "Expected at least one IPv4 address");
if (addressFamily == AddressFamily.InterNetwork)
{
Assert.Contains(entry.AddressList, addr => addr.AddressFamily == addressFamily);
}

if (strictAddressFamily)
{
Assert.All(entry.AddressList, addr => Assert.Equal(addressFamily, addr.AddressFamily));
}
}
Assert.All(entry.AddressList, addr => Assert.Equal(addressFamily, addr.AddressFamily));
}

// RFC 6761: Verify that localhost subdomains return loopback addresses.
Expand Down
Loading