[release/7.0-rc1] Optimized string.Replace(char, char) #74047
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
When the remaining length is a multiple of the vector size, then the remainder is processed twice. This is redundant, and not needed. This commit changes that, so that the remainder is processed only once when the remaining elements match.
….Count and added tests for this
… it in string.Replace(char, char)
….GetRawStringDataAsUshort() internal method
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to this area: @dotnet/area-system-runtime Issue DetailsBackport of #67049 to release/7.0-rc1 /cc @danmoseley @gfoidl I'm backporting this as a special case, as discussed with @stephentoub . It missed the cutoff by hours due to unrelated infra issues, and the PR had been open for 5 months.
|
|
@dotnet/dnceng |
We're tracking this via dotnet/arcade#10358, I'll add this data point to the IcM. Looks like it's still active and they've pinged me for comment this morning. |
|
The 13 HTTP failures on RedHat are due to failing to upload some results, which according to Matt is a known issue already tracked. |
ghost
locked as resolved and limited conversation to collaborators
Backport of #67049 to release/7.0-rc1
/cc @danmoseley @gfoidl
I'm backporting this as a special case, as discussed with @stephentoub . It missed the cutoff by hours due to unrelated infra issues, and the PR had been open for 5 months. The improvement is also significant.