Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change signature for diagnostic binaries #74322

Merged
merged 6 commits into from
Aug 22, 2022

Conversation

hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Aug 22, 2022

  • Add DAC signature infrastructure
  • Try using a .NET 6 SDK to enable signing

Use a signing infrastructure orthogonal to microbuild to use other certs for diagnostic binaries.

cc: @dotnet/dotnet-diag @leculver

@ghost
Copy link

ghost commented Aug 22, 2022

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Add DAC signature infrastructure
  • Try using a .NET 6 SDK to enable signing

Use a signing infrastructure orthogonal to microbuild to use other certs for diagnostic binaries.

cc: @dotnet/dotnet-diag @leculver

Author: hoyosjs
Assignees: -
Labels:

area-Diagnostics-coreclr

Milestone: -

@hoyosjs
Copy link
Member Author

hoyosjs commented Aug 22, 2022

@dotnet dotnet deleted a comment from github-actions bot Aug 22, 2022
@dotnet dotnet deleted a comment from github-actions bot Aug 22, 2022
@dotnet dotnet deleted a comment from github-actions bot Aug 22, 2022
@hoyosjs
Copy link
Member Author

hoyosjs commented Aug 22, 2022

/backport to release/7.0-rc1

@github-actions
Copy link
Contributor

Started backporting to release/7.0-rc1: https://github.com/dotnet/runtime/actions/runs/2901995280

@hoyosjs
Copy link
Member Author

hoyosjs commented Aug 22, 2022

Failure is #73688

Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I'm not an expert with these build files, but it all looked reasonable. I assume we'll be manually validating after the build that the binaries got signed appropriately

@hoyosjs hoyosjs merged commit 8b25e31 into dotnet:main Aug 22, 2022
@hoyosjs hoyosjs deleted the juhoyosa/dac-signing-rc1 branch August 22, 2022 21:20
@ghost ghost locked as resolved and limited conversation to collaborators Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants