-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change signature for diagnostic binaries #74322
Conversation
Add signing with special signature to DAC and DBI.
Tagging subscribers to this area: @tommcdon Issue Details
Use a signing infrastructure orthogonal to microbuild to use other certs for diagnostic binaries. cc: @dotnet/dotnet-diag @leculver
|
975ec67
to
ab5bf51
Compare
/backport to release/7.0-rc1 |
Started backporting to release/7.0-rc1: https://github.com/dotnet/runtime/actions/runs/2901995280 |
Failure is #73688 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm not an expert with these build files, but it all looked reasonable. I assume we'll be manually validating after the build that the binaries got signed appropriately
Use a signing infrastructure orthogonal to microbuild to use other certs for diagnostic binaries.
cc: @dotnet/dotnet-diag @leculver