Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid allocation X509Chain if there is no certificate #74616

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Aug 26, 2022

Introduced by #68188. macOS and Windows check for validity but on Linux it would just fall-through even if there is no peer's certificate.

@wfurt wfurt added area-System.Net.Security os-linux Linux OS (any supported distro) labels Aug 26, 2022
@wfurt wfurt requested a review from a team August 26, 2022 01:33
@wfurt wfurt self-assigned this Aug 26, 2022
@ghost
Copy link

ghost commented Aug 26, 2022

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Introduced by #68188. macOS and Windows check for validity but on Linux it would just fall-through even if there is no peer's certificate.

Author: wfurt
Assignees: wfurt
Labels:

area-System.Net.Security, os-linux

Milestone: -

Copy link
Member

@rzikm rzikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wfurt
Copy link
Member Author

wfurt commented Aug 26, 2022

test failures unrelated #74443 and #73688.

@wfurt wfurt merged commit a3960a8 into dotnet:main Aug 26, 2022
@wfurt wfurt deleted the 509chain branch August 26, 2022 19:16
@karelz karelz added this to the 8.0.0 milestone Aug 26, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net.Security os-linux Linux OS (any supported distro)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants