Ensure that the new Vector512 related ISAs are covered by ILLink Substitutions #83040
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using System; | ||
| using System.Diagnostics.CodeAnalysis; | ||
| using System.Runtime.CompilerServices; | ||
| using System.Runtime.Intrinsics; | ||
|
|
||
| namespace System.Runtime.Intrinsics.X86 | ||
| { | ||
| /// <summary>This class provides access to X86 AVX512BW hardware instructions via intrinsics</summary> | ||
| [CLSCompliant(false)] | ||
| public abstract class Avx512BW : Avx512F | ||
| { | ||
| internal Avx512BW() { } | ||
|
|
||
| public static new bool IsSupported { [Intrinsic] get { return false; } } | ||
|
|
||
| public new abstract class VL : Avx512F.VL | ||
| { | ||
| internal VL() { } | ||
|
|
||
| public static new bool IsSupported { [Intrinsic] get { return false; } } | ||
| } | ||
|
|
||
| public new abstract class X64 : Avx512F.X64 | ||
| { | ||
| internal X64() { } | ||
|
|
||
| public static new bool IsSupported { [Intrinsic] get { return false; } } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using System.Diagnostics.CodeAnalysis; | ||
| using System.Runtime.CompilerServices; | ||
|
|
||
| namespace System.Runtime.Intrinsics.X86 | ||
| { | ||
| /// <summary>This class provides access to X86 AVX512BW hardware instructions via intrinsics</summary> | ||
| [Intrinsic] | ||
| [CLSCompliant(false)] | ||
| public abstract class Avx512BW : Avx512F | ||
| { | ||
| internal Avx512BW() { } | ||
|
|
||
| public static new bool IsSupported { get => IsSupported; } | ||
|
|
||
| [Intrinsic] | ||
| public new abstract class VL : Avx512F.VL | ||
|
There was a problem hiding this comment. Do the public nested types need doc comments? There was a problem hiding this comment. Yes, but it looks like "all" of them are currently missing for I'll log an issue and gets this handled in a follow up PR later tonight. |
||
| { | ||
| internal VL() { } | ||
|
|
||
| public static new bool IsSupported { get => IsSupported; } | ||
| } | ||
|
|
||
| [Intrinsic] | ||
| public new abstract class X64 : Avx512F.X64 | ||
| { | ||
| internal X64() { } | ||
|
|
||
| public static new bool IsSupported { get => IsSupported; } | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using System; | ||
| using System.Diagnostics.CodeAnalysis; | ||
| using System.Runtime.CompilerServices; | ||
| using System.Runtime.Intrinsics; | ||
|
|
||
| namespace System.Runtime.Intrinsics.X86 | ||
| { | ||
| /// <summary>This class provides access to X86 AVX512CD hardware instructions via intrinsics</summary> | ||
| [CLSCompliant(false)] | ||
| public abstract class Avx512CD : Avx512F | ||
| { | ||
| internal Avx512CD() { } | ||
|
|
||
| public static new bool IsSupported { [Intrinsic] get { return false; } } | ||
|
|
||
| public new abstract class VL : Avx512F.VL | ||
| { | ||
| internal VL() { } | ||
|
|
||
| public static new bool IsSupported { [Intrinsic] get { return false; } } | ||
| } | ||
|
|
||
| public new abstract class X64 : Avx512F.X64 | ||
| { | ||
| internal X64() { } | ||
|
|
||
| public static new bool IsSupported { [Intrinsic] get { return false; } } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using System.Diagnostics.CodeAnalysis; | ||
| using System.Runtime.CompilerServices; | ||
|
|
||
| namespace System.Runtime.Intrinsics.X86 | ||
| { | ||
| /// <summary>This class provides access to X86 AVX512CD hardware instructions via intrinsics</summary> | ||
| [Intrinsic] | ||
| [CLSCompliant(false)] | ||
| public abstract class Avx512CD : Avx512F | ||
| { | ||
| internal Avx512CD() { } | ||
|
|
||
| public static new bool IsSupported { get => IsSupported; } | ||
|
|
||
| [Intrinsic] | ||
| public new abstract class VL : Avx512F.VL | ||
| { | ||
| internal VL() { } | ||
|
|
||
| public static new bool IsSupported { get => IsSupported; } | ||
| } | ||
|
|
||
| [Intrinsic] | ||
| public new abstract class X64 : Avx512F.X64 | ||
| { | ||
| internal X64() { } | ||
|
|
||
| public static new bool IsSupported { get => IsSupported; } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using System; | ||
| using System.Diagnostics.CodeAnalysis; | ||
| using System.Runtime.CompilerServices; | ||
| using System.Runtime.Intrinsics; | ||
|
|
||
| namespace System.Runtime.Intrinsics.X86 | ||
| { | ||
| /// <summary>This class provides access to X86 AVX512DQ hardware instructions via intrinsics</summary> | ||
| [CLSCompliant(false)] | ||
| public abstract class Avx512DQ : Avx512F | ||
| { | ||
| internal Avx512DQ() { } | ||
|
|
||
| public static new bool IsSupported { [Intrinsic] get { return false; } } | ||
|
|
||
| public new abstract class VL : Avx512F.VL | ||
| { | ||
| internal VL() { } | ||
|
|
||
| public static new bool IsSupported { [Intrinsic] get { return false; } } | ||
| } | ||
|
|
||
| public new abstract class X64 : Avx512F.X64 | ||
| { | ||
| internal X64() { } | ||
|
|
||
| public static new bool IsSupported { [Intrinsic] get { return false; } } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using System.Diagnostics.CodeAnalysis; | ||
| using System.Runtime.CompilerServices; | ||
|
|
||
| namespace System.Runtime.Intrinsics.X86 | ||
| { | ||
| /// <summary>This class provides access to X86 AVX512DQ hardware instructions via intrinsics</summary> | ||
| [Intrinsic] | ||
| [CLSCompliant(false)] | ||
| public abstract class Avx512DQ : Avx512F | ||
| { | ||
| internal Avx512DQ() { } | ||
|
|
||
| public static new bool IsSupported { get => IsSupported; } | ||
|
|
||
| [Intrinsic] | ||
| public new abstract class VL : Avx512F.VL | ||
| { | ||
| internal VL() { } | ||
|
|
||
| public static new bool IsSupported { get => IsSupported; } | ||
| } | ||
|
|
||
| [Intrinsic] | ||
| public new abstract class X64 : Avx512F.X64 | ||
| { | ||
| internal X64() { } | ||
|
|
||
| public static new bool IsSupported { get => IsSupported; } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using System; | ||
| using System.Diagnostics.CodeAnalysis; | ||
| using System.Runtime.CompilerServices; | ||
| using System.Runtime.Intrinsics; | ||
|
|
||
| namespace System.Runtime.Intrinsics.X86 | ||
| { | ||
| /// <summary>This class provides access to X86 AVX512F hardware instructions via intrinsics</summary> | ||
| [CLSCompliant(false)] | ||
| public abstract class Avx512F : Avx2 | ||
| { | ||
| internal Avx512F() { } | ||
|
|
||
| public static new bool IsSupported { [Intrinsic] get { return false; } } | ||
|
|
||
| public abstract class VL | ||
| { | ||
| internal VL() { } | ||
|
|
||
| public static bool IsSupported { [Intrinsic] get { return false; } } | ||
| } | ||
|
|
||
| public new abstract class X64 : Avx2.X64 | ||
| { | ||
| internal X64() { } | ||
|
|
||
| public static new bool IsSupported { [Intrinsic] get { return false; } } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using System.Diagnostics.CodeAnalysis; | ||
| using System.Runtime.CompilerServices; | ||
|
|
||
| namespace System.Runtime.Intrinsics.X86 | ||
| { | ||
| /// <summary>This class provides access to X86 AVX512F hardware instructions via intrinsics</summary> | ||
| [Intrinsic] | ||
| [CLSCompliant(false)] | ||
| public abstract class Avx512F : Avx2 | ||
| { | ||
| internal Avx512F() { } | ||
|
|
||
| public static new bool IsSupported { get => IsSupported; } | ||
|
|
||
| [Intrinsic] | ||
| public abstract class VL | ||
| { | ||
| internal VL() { } | ||
|
|
||
| public static bool IsSupported { get => IsSupported; } | ||
| } | ||
|
|
||
| [Intrinsic] | ||
| public new abstract class X64 : Avx2.X64 | ||
| { | ||
| internal X64() { } | ||
|
|
||
| public static new bool IsSupported { get => IsSupported; } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need ILLink.Substitution entries for these when we also have the
.PlatformNotSupported.csversions that just returnfalse? This xml file seems to be included in the same condition as when those .cs files are used.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure actually. Maybe some legacy thing from back when they weren't guaranteed false?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like I originally did it in ee12b54, but looking back I'm not sure it is needed. Since we are just following existing convention here, let's not block this PR on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#83164