Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] System.Net.WebSockets.Client.Tests timeouts #85167

Merged
merged 3 commits into from
Apr 24, 2023
Merged

[wasm] System.Net.WebSockets.Client.Tests timeouts #85167

merged 3 commits into from
Apr 24, 2023

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Apr 21, 2023 •
edited
Loading

exploring #84101

@pavelsavara pavelsavara added this to the 8.0.0 milestone Apr 21, 2023
@pavelsavara pavelsavara self-assigned this Apr 21, 2023
@ghost
Copy link

ghost commented Apr 21, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

exploring ...

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone: 8.0.0

@pavelsavara pavelsavara requested a review from maraf April 21, 2023 17:33
@pavelsavara pavelsavara marked this pull request as ready for review April 21, 2023 17:33
This was referenced Apr 21, 2023
Closed
Closed
kg
kg reviewed Apr 23, 2023
View reviewed changes
Copy link
Member

@kg kg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be additional log spew here, is that intentional? Looks OK otherwise

maraf
maraf approved these changes Apr 24, 2023
View reviewed changes
src/mono/wasm/runtime/logging.ts Outdated Show resolved Hide resolved
@pavelsavara
Copy link
Member Author

There seems to be additional log spew here, is that intentional? Looks OK otherwise

Yes, that's intentional. It would allow me to write better match pattern for "known errors" github issues like #84101

@pavelsavara pavelsavara merged commit c3a2bce into dotnet:main Apr 24, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 24, 2023
@pavelsavara pavelsavara deleted the wasm_websockets_timeout branch September 2, 2024 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kg kg kg left review comments

@maraf maraf maraf approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pavelsavara @kg @maraf