Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpClientHandler request metrics #87319

Merged
merged 31 commits into from
Jul 13, 2023
Merged

HttpClientHandler request metrics #87319

merged 31 commits into from
Jul 13, 2023

Commits on Jun 9, 2023

  1. initial implementation of request metrics

    @antonfirsov
    antonfirsov committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    ec16299 View commit details
    Browse the repository at this point in the history

  2. simplify error handling code and add comments

    @antonfirsov
    antonfirsov committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    2bacea0 View commit details
    Browse the repository at this point in the history

  3. typo

    @antonfirsov
    antonfirsov committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    74597a4 View commit details
    Browse the repository at this point in the history

  4. fix Http.Unit.Tests build failure

    @antonfirsov
    antonfirsov committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    12af084 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. wip

    @antonfirsov
    antonfirsov committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    528f3b1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into MetricsHandler-02

    @antonfirsov
    antonfirsov committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    0d97a7d View commit details
    Browse the repository at this point in the history

  3. callback-based enrichment API with reftype context

    @antonfirsov
    antonfirsov committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    4fcfee6 View commit details
    Browse the repository at this point in the history

  4. Protect against re-reentrancy

    @antonfirsov
    antonfirsov committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    bd461c8 View commit details
    Browse the repository at this point in the history

  5. use shared counters with the shared meter

    @antonfirsov
    antonfirsov committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    3c80a0b View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. do not cache instruments already cached by Meter

    @antonfirsov
    antonfirsov committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    7406c46 View commit details
    Browse the repository at this point in the history

  2. use [ThreadStatic] instead of ThreadLocal

    @antonfirsov
    antonfirsov committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    9da9485 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2023

  1. Merge branch 'main' into MetricsHandler-05 

    # Conflicts:
#	src/libraries/System.Net.Http/src/System.Net.Http.csproj
    @antonfirsov
    antonfirsov committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    9251264 View commit details
    Browse the repository at this point in the history

  2. sync with main

    @antonfirsov
    antonfirsov committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    2a90c07 View commit details
    Browse the repository at this point in the history

  3. review feedback

    @antonfirsov
    antonfirsov committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    869bd34 View commit details
    Browse the repository at this point in the history

  4. use FrozenDictionary for caching status codes

    @antonfirsov
    antonfirsov committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    1d43c3e View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2023

  1. Merge branch 'main' into MetricsHandler-02 

    # Conflicts:
#	src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/SocketsHttpHandler.cs
    @antonfirsov
    antonfirsov committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    d4eadb1 View commit details
    Browse the repository at this point in the history

  2. implement final design

    @antonfirsov
    antonfirsov committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    493e7d8 View commit details
    Browse the repository at this point in the history

  3. fixup merge

    @antonfirsov
    antonfirsov committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    d049d4f View commit details
    Browse the repository at this point in the history

  4. rename "contextCache" to "pool"

    @antonfirsov
    antonfirsov committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    6d4cd18 View commit details
    Browse the repository at this point in the history

  5. comments

    @antonfirsov
    antonfirsov committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    9f4dd8e View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Simplify status code cache 

    Co-authored-by: Miha Zupan <[email protected]>
    @antonfirsov @MihaZupan
    antonfirsov and MihaZupan authored Jul 11, 2023
    Configuration menu
    Copy the full SHA
    df6189e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'MetricsHandler-02' of https://github.com/antonfirsov/ru… 

    …ntime into MetricsHandler-02
    @antonfirsov
    antonfirsov committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    bbc38af View commit details
    Browse the repository at this point in the history

  3. review feedback

    @antonfirsov
    antonfirsov committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    cd5e4a4 View commit details
    Browse the repository at this point in the history

  4. move instrument names to constants in tests

    @antonfirsov
    antonfirsov committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    62f87b2 View commit details
    Browse the repository at this point in the history

  5. harden HttpMetricsTest_DefaultMeter

    @antonfirsov
    antonfirsov committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    6283c24 View commit details
    Browse the repository at this point in the history

  6. remove unnecessary reference to System.Collections.Immutable

    @antonfirsov
    antonfirsov committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    6b77359 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. lazy-init s_boxedStatusCodes

    @antonfirsov
    antonfirsov committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    f61c85b View commit details
    Browse the repository at this point in the history

  2. oops

    @antonfirsov
    antonfirsov committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    9eb314e View commit details
    Browse the repository at this point in the history

  3. simplify HttpMetricsTest_DefaultMeter.RequestDuration_Success_Recorde… 

    …d to avoid (likely environmental) failures on Android
    @antonfirsov
    antonfirsov committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    8e35e19 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. move the default meter tests out of process

    @antonfirsov
    antonfirsov committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    1e7453f View commit details
    Browse the repository at this point in the history

  2. oops

    @antonfirsov
    antonfirsov committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    e686bee View commit details
    Browse the repository at this point in the history