Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/arcade dotnet/xharness dotnet/emsdk #88827

Merged
merged 8 commits into from
Jul 14, 2023
Merged

[main] Update dependencies from dotnet/arcade dotnet/xharness dotnet/emsdk #88827

merged 8 commits into from
Jul 14, 2023

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jul 13, 2023 •
edited
Loading

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.SourceLink.GitHub: from 8.0.0-beta.23360.2 to 8.0.0-beta.23361.2 (parent: Microsoft.DotNet.Arcade.Sdk)
    • Microsoft.DotNet.XliffTasks: from 1.0.0-beta.23326.1 to 1.0.0-beta.23360.1 (parent: Microsoft.DotNet.Arcade.Sdk)

From https://github.com/dotnet/arcade

  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20230712.5
  • Date Produced: July 12, 2023 9:07:04 PM UTC
  • Commit: 7f922d5c3edb921ed36d169263c55065e235b333
  • Branch: refs/heads/main
  • Updates to .NET SDKs:
    • Updates sdk.version to 8.0.100-preview.6.23330.14
    • Updates tools.dotnet to 8.0.100-preview.6.23330.14

From https://github.com/dotnet/emsdk

  • Subscription: c22d5069-447c-4252-29fd-08d90a7bb4bc
  • Build: 20230712.1
  • Date Produced: July 12, 2023 8:44:02 PM UTC
  • Commit: 96c6e0d2c0bb8a90d6b49eb3ffa32593f7df7a18
  • Branch: refs/heads/main

From https://github.com/dotnet/xharness

  • Subscription: be30ac4f-4b72-4287-1eb6-08d8d8fef0ea
  • Build: 20230713.3
  • Date Produced: July 13, 2023 3:35:58 PM UTC
  • Commit: b0548ed270ed98fa14ab0fcc5ef7af99fad00237
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
5566501 
…712.5

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23361.1 -> To Version 8.0.0-beta.23362.5

Dependency coherency updates

Microsoft.SourceLink.GitHub,Microsoft.DotNet.XliffTasks
 From Version 8.0.0-beta.23360.2 -> To Version 8.0.0-beta.23361.2 (parent: Microsoft.DotNet.Arcade.Sdk
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Jul 13, 2023
@dotnet-maestro
Update dependencies from https://github.com/dotnet/emsdk build 202307…
9618c4b 
…12.1

Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
 From Version 8.0.0-preview.7.23361.2 -> To Version 8.0.0-preview.7.23362.1
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/arcade [main] Update dependencies from dotnet/arcade dotnet/emsdk Jul 13, 2023
@lewing
Copy link
Member

lewing commented Jul 13, 2023

@ViktorHofer are the sourcelink errors related to your revert?

@ViktorHofer
Copy link
Member

Yes, will take a look.

@lewing
Copy link
Member

lewing commented Jul 13, 2023

And now it appears the sdk bump is the issue

@lewing
Copy link
Member

lewing commented Jul 13, 2023

@elinor-fung this looks like dotnet/sdk#33486 as we take the new sdk into runtime

@lewing lewing mentioned this pull request Jul 13, 2023
Open
This was referenced Jul 13, 2023
Open
Closed
@elinor-fung
Copy link
Member

elinor-fung commented Jul 13, 2023 •
edited
Loading

Couple of different things hitting NETSDK1206:

  • System.Net.Quic (windows and osx)
    • I think this is because we have no framework references (since this is the framework) - and the warning relies on processing framework references to determine known RIDs
  • Microsoft.Extensions.DependencyInjection.Specification.Tests
    • Due to netstandard packages that have non-portable RIDs. These will never get used at run time. In regular builds, they would be removed by conflict resolution and wouldn't show up in the dependences (so no warning). But conflict resolution uses the ref package platform manifest, may not be generated yet (I believe libs.pretest generates it).
  • Microsoft.Extensions.Logging.Generators.Tests
    • Warning doesn't represent a functional issue, since the package has a copy of the same binaries in the equivalent portable RID
      • SQLitePCLRaw owner has updated, but hasn't released a new version yet

Still looking at System.Net.Quic - will need to update the SDK to handle this case and add a workaround in this repo.

@elinor-fung elinor-fung mentioned this pull request Jul 13, 2023
Closed
@build-analysis build-analysis bot mentioned this pull request Jul 14, 2023
Open
@ViktorHofer
Copy link
Member

ViktorHofer commented Jul 14, 2023 •
edited
Loading

cc @ericstj regarding our custom RID builds in libraries

@dotnet-maestro
Update dependencies from https://github.com/dotnet/xharness build 202…
ce6f27d 
…30713.3

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 8.0.0-prerelease.23360.3 -> To Version 8.0.0-prerelease.23363.3
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/arcade dotnet/emsdk [main] Update dependencies from dotnet/arcade dotnet/emsdk dotnet/xharness Jul 14, 2023
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/arcade dotnet/emsdk dotnet/xharness [main] Update dependencies from dotnet/arcade dotnet/xharness dotnet/emsdk Jul 14, 2023
ericstj
ericstj reviewed Jul 14, 2023
View reviewed changes
....Specification.Tests/src/Microsoft.Extensions.DependencyInjection.Specification.Tests.csproj Outdated
They won't actually get used at run time - package conflict resolution would normally handle removing them. However,
due to the way the repo builds, the platform manifest for the ref package has not yet been generated when this test
is being built, so they are not removed (and the SDK warns on it). -->
<NoWarn>$(NoWarn);NETSDK1206</NoWarn>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just reference a later NETStandard.Library to avoid those dependencies? The latest NETStandard.Library package won't bring in the old PackageReferences.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please add a PackageRefernce to NetStandard.Library with PrivateAssets="all"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check 2adf3d9 is what you mean?

@ericstj
Copy link
Member

ericstj commented Jul 14, 2023

cc @ericstj regarding our custom RID builds in libraries

I'm not entirely sure what you want me to look at, gave my best guess based on the state of this PR. Looks like remaining blockers are test failures.

@ericstj
Copy link
Member

ericstj commented Jul 14, 2023

The TimeZone test failures here seem to be caused by #88641 cc @RenderMichael @tarekgh

@tarekgh
Copy link
Member

tarekgh commented Jul 14, 2023

The TimeZone test failures here seem to be caused by #88641

This has been fixed by @akoeplinger through the PR #88909.

This was referenced Jul 14, 2023
Closed
Closed
@lewing
Copy link
Member

lewing commented Jul 14, 2023 •
edited
Loading

failures are known #88870 and #84995

@lewing lewing merged commit b40d643 into main Jul 14, 2023
@lewing lewing deleted the darc-main-7be5ed93-e5c1-47ff-84b2-8b0174c1eee7 branch July 14, 2023 19:03
@ghost ghost locked as resolved and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elinor-fung elinor-fung elinor-fung left review comments

@ericstj ericstj ericstj left review comments

@ViktorHofer ViktorHofer ViktorHofer left review comments

@lewing lewing lewing approved these changes

Assignees
No one assigned
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lewing @ViktorHofer @elinor-fung @ericstj @tarekgh