Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[automated] Merge branch 'release/5.0.2xx' => 'master' #14871

Merged

Conversation

dotnet-maestro-bot
Copy link
Contributor

I detected changes in the release/5.0.2xx branch which have not been merged yet to master. I'm a robot and am configured to help you automatically keep master up to date, so I've opened this PR.

This PR merges commits made on release/5.0.2xx by the following committers:

  • dotnet-maestro[bot]
  • dsplaisted
  • AntonLapounov
  • sfoslund
  • mavasani
  • wli3
  • mmitche
  • nkolev92
  • v-wuzhai
  • marcpopMSFT
  • baronfel
  • rainersigwald

Instructions for merging from UI

This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.

merge button instructions

If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.

Instructions for merging via command line

Run these commands to merge this pull request from the command line.

git fetch
git checkout release/5.0.2xx
git pull --ff-only
git checkout master
git pull --ff-only
git merge --no-ff release/5.0.2xx

# If there are merge conflicts, resolve them and then run git merge --continue to complete the merge
# Pushing the changes to the PR branch will re-trigger PR validation.
git push https://github.com/dotnet-maestro-bot/sdk HEAD:merge/release/5.0.2xx-to-master
or if you are using SSH
git push [email protected]:dotnet-maestro-bot/sdk HEAD:merge/release/5.0.2xx-to-master

After PR checks are complete push the branch

git push

Instructions for resolving conflicts

⚠️ If there are merge conflicts, you will need to resolve them manually before merging. You can do this using GitHub or using the command line.

Instructions for updating this pull request

Contributors to this repo have permission update this pull request by pushing to the branch 'merge/release/5.0.2xx-to-master'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.

git checkout -b merge/release/5.0.2xx-to-master master
git pull https://github.com/dotnet-maestro-bot/sdk merge/release/5.0.2xx-to-master
(make changes)
git commit -m "Updated PR with my changes"
git push https://github.com/dotnet-maestro-bot/sdk HEAD:merge/release/5.0.2xx-to-master
or if you are using SSH
git checkout -b merge/release/5.0.2xx-to-master master
git pull [email protected]:dotnet-maestro-bot/sdk merge/release/5.0.2xx-to-master
(make changes)
git commit -m "Updated PR with my changes"
git push [email protected]:dotnet-maestro-bot/sdk HEAD:merge/release/5.0.2xx-to-master

Contact .NET Core Engineering if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/master/scripts/GitHubMergeBranches.ps1.

rainersigwald and others added 30 commits September 14, 2020 09:54
Fixes dotnet#13491 by passing standard property to the additional csc invocation used for satellite assemblies.
Add FSharp.Core docs to the set of files to be published
This is the first step towards flipping the default value, it will find the places where we are not setting it explicitly.
… not include any projects that compile for net472 as it didn't seem worth the code complexity it nor any test projects.
…net#14468)

[release/5.0.2xx] Update dependencies from dotnet/windowsdesktop
- Coherency Updates:
  - Microsoft.NET.Sdk.WindowsDesktop: from 5.0.0-rtm.20529.5 to 5.0.0-rtm.20559.1 (parent: Microsoft.WindowsDesktop.App)
  - Microsoft.DotNet.Wpf.ProjectTemplates: from 5.0.0-rtm.20529.5 to 5.0.0-rtm.20559.1 (parent: Microsoft.WindowsDesktop.App)
  - Microsoft.Dotnet.WinForms.ProjectTemplates: from 5.0.0-rtm.20529.3 to 5.0.1-servicing.20559.1 (parent: Microsoft.WindowsDesktop.App)
…ld 20201109.3 (dotnet#14472)

[release/5.0.2xx] Update dependencies from dotnet/windowsdesktop
- Coherency Updates:
  - Microsoft.NET.Sdk.WindowsDesktop: from 5.0.0-rtm.20559.1 to 5.0.0-rtm.20559.2 (parent: Microsoft.WindowsDesktop.App)
  - Microsoft.DotNet.Wpf.ProjectTemplates: from 5.0.0-rtm.20559.1 to 5.0.0-rtm.20559.2 (parent: Microsoft.WindowsDesktop.App)
  - Microsoft.Dotnet.WinForms.ProjectTemplates: from 5.0.1-servicing.20559.1 to 5.0.1-servicing.20559.3 (parent: Microsoft.WindowsDesktop.App)
…110.3 (dotnet#14479)

[release/5.0.2xx] Update dependencies from dotnet/arcade
…net#14481)

[release/5.0.2xx] Update dependencies from dotnet/windowsdesktop
- Coherency Updates:
  - Microsoft.NET.Sdk.WindowsDesktop: from 5.0.0-rtm.20559.2 to 5.0.0-rtm.20560.2 (parent: Microsoft.WindowsDesktop.App)
  - Microsoft.DotNet.Wpf.ProjectTemplates: from 5.0.0-rtm.20559.2 to 5.0.0-rtm.20560.2 (parent: Microsoft.WindowsDesktop.App)
…0201110.2 (dotnet#14486)

[release/5.0.2xx] Update dependencies from dotnet/templating
…#14433)

[release/5.0.2xx] Update dependencies from nuget/nuget.client


 - Check for unsupported platform identifier before CollectPackageReferences

See discussion in dotnet#14433

 - Merge upstream changes
…net#14495)

[release/5.0.2xx] Update dependencies from dotnet/windowsdesktop
- Coherency Updates:
  - Microsoft.NET.Sdk.WindowsDesktop: from 5.0.0-rtm.20560.2 to 5.0.0-rtm.20560.4 (parent: Microsoft.WindowsDesktop.App)
  - Microsoft.DotNet.Wpf.ProjectTemplates: from 5.0.0-rtm.20560.2 to 5.0.0-rtm.20560.4 (parent: Microsoft.WindowsDesktop.App)
  - Microsoft.Dotnet.WinForms.ProjectTemplates: from 5.0.1-servicing.20559.3 to 5.0.1-servicing.20560.2 (parent: Microsoft.WindowsDesktop.App)
…dkstyle

Default TestProject.IsSdkProject to true
…net#14501)

[release/5.0.2xx] Update dependencies from dotnet/windowsdesktop
- Coherency Updates:
  - Microsoft.NET.Sdk.WindowsDesktop: from 5.0.0-rtm.20560.4 to 5.0.1-servicing.20561.1 (parent: Microsoft.WindowsDesktop.App)
  - Microsoft.DotNet.Wpf.ProjectTemplates: from 5.0.0-rtm.20560.4 to 5.0.1-servicing.20561.1 (parent: Microsoft.WindowsDesktop.App)
Pass Optimize to CoreGenerateSatelliteAssemblies
…ld 20201112.1 (dotnet#14521)

[release/5.0.2xx] Update dependencies from dotnet/windowsdesktop
- Coherency Updates:
  - Microsoft.NET.Sdk.WindowsDesktop: from 5.0.1-servicing.20561.1 to 5.0.1-servicing.20561.15 (parent: Microsoft.WindowsDesktop.App)
  - Microsoft.DotNet.Wpf.ProjectTemplates: from 5.0.1-servicing.20561.1 to 5.0.1-servicing.20561.15 (parent: Microsoft.WindowsDesktop.App)
  - Microsoft.Dotnet.WinForms.ProjectTemplates: from 5.0.1-servicing.20560.2 to 5.0.1-servicing.20561.12 (parent: Microsoft.WindowsDesktop.App)
…1113.5 (dotnet#14538)

[release/5.0.2xx] Update dependencies from dotnet/runtime
…1113.12 (dotnet#14543)

[release/5.0.2xx] Update dependencies from dotnet/runtime
…0201116.2 (dotnet#14559)

[release/5.0.2xx] Update dependencies from dotnet/templating
* Update dependencies from https://github.com/dotnet/runtime build 20201116.8

Microsoft.NETCore.App.Internal , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.App.Runtime.win-x64
 From Version 5.0.0-rtm.20563.12 -> To Version 5.0.1-servicing.20566.8

* Update dependencies from https://github.com/dotnet/runtime build 20201117.12

Microsoft.NETCore.App.Internal , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.App.Runtime.win-x64
 From Version 5.0.0-rtm.20519.4 -> To Version 5.0.1-servicing.20567.12

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Jason Zhai <[email protected]>
[release/5.0.2xx] Update dependencies from dotnet/runtime
Updated to OperationSystem.IsWindows and co.
[release/5.0.2xx] Update dependencies from dotnet/runtime
…5.9.0.6967 (dotnet#14604)

NuGet.Build.Tasks
 From Version 5.9.0-preview.1.6955 -> To Version 5.9.0-preview.2.6967

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Jason Zhai <[email protected]>
…1120.12 (dotnet#14648)

[release/5.0.2xx] Update dependencies from dotnet/runtime
…0201110.12

dotnet-dev-certs , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Analyzers , dotnet-watch , dotnet-user-secrets , VS.Redist.Common.AspNetCore.SharedFramework.x64.5.0 , Microsoft.NET.Sdk.Razor , Microsoft.NET.Sdk.BlazorWebAssembly , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.Mvc.Analyzers
 From Version 5.0.1-servicing.20566.11 -> To Version 5.0.1-servicing.20560.12
dotnet-maestro bot and others added 16 commits December 2, 2020 17:40
…202.2 (dotnet#14805)

[release/5.0.2xx] Update dependencies from dotnet/roslyn
…iveFrameworkReferenceAttribute

Add transitive framework reference attribute
Default 'AnalysisLevel' if 'AnalysisMode' has been set
Includes NETCoreSdkRuntimeIdentifierChain.txt file
…uild 20201203.1 (dotnet#14825)

[release/5.0.2xx] Update dependencies from dotnet/roslyn-analyzers
…uild 20201203.4 (dotnet#14831)

[release/5.0.2xx] Update dependencies from dotnet/roslyn-analyzers
…timeidentifier

Use list of current Runtime Identifiers for workload resolver
…rmTarget

Allow inferring ARM64 PlatformTarget from RID
…5.9.0.6979 (dotnet#14865)

[release/5.0.2xx] Update dependencies from nuget/nuget.client
dotnet-maestro bot and others added 2 commits December 7, 2020 23:30
Copy link
Member

@v-wuzhai v-wuzhai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wli3 @sfoslund I resolved the conflicts, do we need to merge it?

@sfoslund
Copy link
Member

sfoslund commented Dec 8, 2020

Found .NET SDK, but did not find dotnet.dll

Yes, we will want to merge this once we resolve the test failures.

It looks like this line shows up in the merge and is causing the failures, is it needed @wli3?
<OverlaySdkFilesFromStage0 Include="$(_DotNetHiveRoot)/sdk/$(Stage0SdkVersion)/NETCoreSdkRuntimeIdentifierChain.txt" />

@wli3
Copy link

wli3 commented Dec 9, 2020

<OverlaySdkFilesFromStage0 Include="$(_DotNetHiveRoot)/sdk/$(Stage0SdkVersion)/NETCoreSdkRuntimeIdentifierChain.txt" />

is needed in master. @dsplaisted added the feature so that we can use the RID chain (generate in build time of dotnet/installer) to find the most fit pack instead of a hard coded list.

@dsplaisted
Copy link
Member

Looks like we don't have test coverage of the NETCoreSdkRuntimeIdentifierChain.txt file. I added a note to add that as part of #14841.

Ideally we would merge 5.0.2xx to master for dotnet/installer, then update this PR to use the updated stage 0, and include the file in the list to copy from Stage 0.

@dsplaisted
Copy link
Member

Here's the merge to master for dotnet/installer: dotnet/installer#9203

@dsplaisted dsplaisted merged commit 61e32e2 into dotnet:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.