Add test case for adding projects outside solution dir descendants #46835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
edvilme
force-pushed
the
edvilme-sln-add-parent
branch
from
75f869a to
600b6fe
Compare
There was a problem hiding this comment.
Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (3)
- test/TestAssets/TestProjects/TestAppWithSlnAndCsprojInParentDir/Dir/App.sln: Language not supported
- test/TestAssets/TestProjects/TestAppWithSlnAndCsprojInParentDir/Dir/App.slnx: Language not supported
- test/TestAssets/TestProjects/TestAppWithSlnAndCsprojInParentDir/Lib/Lib.csproj: Language not supported
Comments suppressed due to low confidence (1)
test/dotnet-sln.Tests/GivenDotnetSlnAdd.cs:1114
- The test case should verify the contents of the solution file after the project is added to ensure the expected behavior is met.
cmd.Should().Pass(); // TODO: Check actual contents
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Forgind
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing tests for #46456
This has apparently been a common issue that was not considered when migrating to the new solutionpersistence parser due to a lack of tests.
This adds a simple test scenario to avoid breaking this behavior in the future.