-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dotnet sln remove
smart project matching
#47112
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/Cli/dotnet/commands/dotnet-sln/remove/Program.cs:80
- The empty catch block may suppress unexpected exceptions that could help diagnose issues. Consider catching a specific exception or logging the caught exception to aid in troubleshooting.
if (project is null && !Path.HasExtension(projectPath)) { try { ... } catch { project = null; } }
sln remove
smart project matching
sln remove
smart project matchingdotnet sln remove
smart project matching
This seems like a good idea. I haven't run into this but I can see how annoying the current behavior would be. |
Couple design remarks
|
ce6f475
to
ca42c84
Compare
ca42c84
to
4615216
Compare
Re-targeted to |
Fixes #47111
This would find a .csproj file named baz.csproj in the solution, independent of the path to the project. If there is a conflict (aka, multiple baz.csproj files), it would error. Otherwise, it would do the smart thing, find the project defined as foo/bar/baz/baz.csproj and remove it.