Skip to content

Conversation

maraf
Copy link
Member

@maraf maraf commented Apr 16, 2025

Contributes to dotnet/runtime#77191
Pre-requisite for dotnet/runtime#114686

@maraf maraf added this to the 10.0.1xx milestone Apr 16, 2025
@maraf maraf requested a review from a team April 16, 2025 12:48
@maraf maraf self-assigned this Apr 16, 2025
@Copilot Copilot AI review requested due to automatic review settings April 16, 2025 12:48
@ghost ghost added the untriaged Request triage from a team member label Apr 16, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

test/Microsoft.NET.TestFramework/AspNetSdkTest.cs:65

  • [nitpick] The variable name 'fingerprintAssets' does not clearly convey its purpose. Consider renaming it to 'wasmInlineBootConfigElement' to improve clarity.
var fingerprintAssets = new XElement("WasmInlineBootConfig", "false");

@maraf maraf removed the untriaged Request triage from a team member label Apr 16, 2025
@maraf maraf removed this from the 10.0.1xx milestone Apr 16, 2025
@maraf maraf changed the title [wasm] Explicitly opt-out from inlining boot config [wasm] Explicitly opt-out from inlining boot config in tests Apr 16, 2025
@maraf maraf merged commit 3d1bcd8 into main Apr 17, 2025
39 checks passed
@maraf maraf deleted the WasmNotInlineBootConfig branch April 17, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants