-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Multi-RID tool packages usability tweaks #49288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
06fa327
remove version from rid-specific tool package metadata - all versions…
baronfel c70bf75
make tool packages publish instead of build
baronfel d87a4af
use more precise apphost-detection for command entrypoint
baronfel 11ae747
don't use Items for ToolPackageRuntimeIdentifier - use a property ins…
baronfel 0a37671
condition the PackTool targets so that only tool packages get the cha…
baronfel 09e7d95
add RID to RID-specific tool package paths for future-proofing
baronfel 944555c
ensure RID-specific packages get correct entrypoint and package type
baronfel b7b58e4
don't throw on RID-mismatch
baronfel 5406dc1
handle multi-RID publishing as part of outer-packaging
baronfel 3dcd541
simplify cross-arch packaging
baronfel bcbd802
re-add error when installing a RID-specific package but no matching R…
baronfel 6dc57ca
remove ResolveToolPackagePaths now that it's computed in the targets …
baronfel 9a15035
Don't have Pack call PackTool unless the package is a tool
baronfel 897c950
only do tool-packaging things during publish if the published project…
baronfel d3332f9
restore RID-agnostic-only tool packaging
baronfel 89b95d4
some more doc comments
baronfel 3f7212d
WIP: diagnosing why shims are ended up in nested dirs during packaging
baronfel 6f65e7a
fix shim path packaging
baronfel 700a921
ensure inner-RID packing only happens for multi-RID tools, not tools …
baronfel b68b27d
Fix apphost inclusion in the RID-agnostic tool packages.
baronfel 7d25694
Green up tests around GeneratePackageOnBuild
baronfel 39efc99
update AOT tool test scenario and fix test breaks
baronfel dc4dca6
temp: add binlogs
baronfel af4ddb4
try to write binlogs to helix upload root
baronfel 92fb63b
fix lookup path for binlogs
baronfel 2444c06
Add test for the multi-package tool creation
baronfel 578eba8
Fix tool shim output path calculation
baronfel 55e5c4d
Remove now-unused Task
baronfel e9f8347
Ensure that RID-specific packages set the right package type
baronfel f37177c
Fix packaging tools that are multi-tfm
baronfel 75b4ee6
Add more documentation comments to Targets files
baronfel 7e9e0cf
React to @nagilson's review feedback
baronfel 227f6b4
fix test case by making it pack as a tool so that the requested targe…
baronfel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 0 additions & 28 deletions
28
src/Tasks/Microsoft.NET.Build.Tasks.UnitTests/GivenAPublishRelativePathToPackPackagePath.cs
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 0 additions & 36 deletions
36
src/Tasks/Microsoft.NET.Build.Tasks/RemoveTargetFromList.cs
This file was deleted.
Oops, something went wrong.
120 changes: 0 additions & 120 deletions
120
src/Tasks/Microsoft.NET.Build.Tasks/ResolveToolPackagePaths.cs
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Late review: Does this now mean that it's not possible to have different versions for the RID-specific packages? I thought we weren't going to support different version numbers for package production, but we were still going to support consuming packages where the primary package has a different version from the RID-specific packages if someone creates packages like that through some other means.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct - I refactored that out in this pass. We could add it back (you're right that the production-side only supports making a single version across all tools), but I am not convinced that we'll ever actually see that scenario happen: IMO the only time you have separate packages being made now is related to AOT packaging, and even that should be really aligned version-wise.