Use NormalizeDirectory instead of Path.Combine for PackagedShimOutputDirectory #49858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tory Follow-up to #49801 and #49288 We were still seeing an error during publish, note the duplicate slashes: ``` error NETSDK1152: Found multiple publish output files with the same relative path: /__w/1/s/artifacts/bin/dotnet-dump/Debug/shims/net8.0/win-x64/dotnet-dump.exe, /__w/1/s/artifacts/bin/dotnet-dump/Debug//shims/net8.0/win-x64/dotnet-dump.exe, /__w/1/s/artifacts/bin/dotnet-dump/Debug/shims/net8.0/win-x86/dotnet-dump.exe, /__w/1/s/artifacts/bin/dotnet-dump/Debug//shims/net8.0/win-x86/dotnet-dump.exe, /__w/1/s/artifacts/bin/dotnet-dump/Debug/shims/net8.0/osx-x64/dotnet-dump ``` Use the [MSBuild]::NormalizePath property function instead of Path.Combine to get a canonicalized path that doesn't contain duplicate slashes.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a path normalization issue that was causing duplicate slashes in file paths during tool publishing, which resulted in NETSDK1152 errors about multiple publish output files with the same relative path. The change replaces [System.IO.Path]::Combine with [MSBuild]::NormalizePath to ensure canonicalized paths without duplicate directory separators.
- Replaces
Path.CombinewithMSBuild.NormalizePathforPackagedShimOutputDirectoryparameter - Affects three locations across two MSBuild target files
- Resolves duplicate slash issues that caused publish conflicts
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Microsoft.NET.Publish.targets | Updates PackagedShimOutputDirectory path construction in GetEmbeddedApphostPaths task |
| Microsoft.NET.PackTool.targets | Updates PackagedShimOutputDirectory path construction in two locations for tool packaging |
|
Shouldn't this use NormalizeDirectory? |
akoeplinger
changed the title
|
Thanks, for some reason I always confuse the two (it still works the same way for directories though, except it won't append the trailing slash) |
baronfel
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #49801 and #49288
We were still seeing an error during publish, note the duplicate slashes:
Use the
[MSBuild]::NormalizeDirectoryproperty function instead ofPath.Combineto get a canonicalized path that doesn't contain duplicate slashes.