Skip to content

[Blazor] Treat RuntimeIdentifiers as local property #50487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 5, 2025
Merged

[Blazor] Treat RuntimeIdentifiers as local property #50487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1ed33e3
Treat RuntimeIdentifiers as local property
maraf Aug 26, 2025
edf8dda
Merge branch 'main' into maraf/BlazorWasmRuntimeIdentifiersLocal
maraf Aug 26, 2025
7bd85b3
Test
maraf Sep 3, 2025
39723e6
Merge branch 'main' into maraf/BlazorWasmRuntimeIdentifiersLocal
maraf Sep 3, 2025
3d4dc30
When casing matters
maraf Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/BlazorWasmSdk/Targets/Microsoft.NET.Sdk.BlazorWebAssembly.Current.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,12 @@ WARNING: DO NOT MODIFY this file unless you are knowledgeable about MSBuild and
Copyright (c) .NET Foundation. All rights reserved.
***********************************************************************************************
-->
<Project ToolsVersion="14.0" TreatAsLocalProperty="RuntimeIdentifier">
<Project ToolsVersion="14.0" TreatAsLocalProperty="RuntimeIdentifier;RuntimeIdentifiers">
<PropertyGroup>
<OutputType>exe</OutputType>

<RuntimeIdentifier>browser-wasm</RuntimeIdentifier>
<RuntimeIdentifiers>$(RuntimeIdentifier)</RuntimeIdentifiers>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure if we should just unset the property entirely or set it to $(RuntimeIdentifier) here. Did you try it both ways? Were there any behavioral differences?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would set this explicitly to browser-wasm

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my testing I didn't find a difference

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a vague recollection of some issue when both RuntimeIdentifiers and RuntimeIdentifier were set but I can't find any details anymore. Maybe it was just when they disagreed.

<AppendRuntimeIdentifierToOutputPath>false</AppendRuntimeIdentifierToOutputPath>
<CopyOutputSymbolsToPublishDirectory>false</CopyOutputSymbolsToPublishDirectory>

Expand Down
17 changes: 17 additions & 0 deletions test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/WasmBuildIntegrationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -697,6 +697,23 @@ public class TestReference
fileInWwwroot.Should().Exist();
}

[RequiresMSBuildVersionFact("17.12", Reason = "Needs System.Text.Json 8.0.5")]
public void Restore_WithRuntime_Works()
{
var testInstance = CreateAspNetSdkTestAsset("BlazorHosted");

var nugetRestorePath = Path.Combine(testInstance.TestRoot, ".nuget");

new DotnetRestoreCommand(Log, "-bl:msbuild-restore.binlog", "-r", "linux-x64")
.WithWorkingDirectory(Path.Combine(testInstance.TestRoot, "blazorhosted"))
.WithEnvironmentVariable("NUGET_PACKAGES", nugetRestorePath)
.Execute()
.Should().Pass();

new DirectoryInfo(Path.Combine(nugetRestorePath, "microsoft.netcore.app.runtime.mono.linux-x64"))
.Should().NotExist();
}

[RequiresMSBuildVersionFact("17.12", Reason = "Needs System.Text.Json 8.0.5")]
public void Build_WithReference_Works()
{
Expand Down