Skip to content

Pass Android target OS to Crossgen2#54387

Merged
simonrozsival merged 2 commits into
mainfrom
dev/srozsival/android-arm-changes
May 20, 2026
Merged

Pass Android target OS to Crossgen2#54387
simonrozsival merged 2 commits into
mainfrom
dev/srozsival/android-arm-changes

Conversation

@simonrozsival

@simonrozsival simonrozsival commented May 19, 2026

Copy link
Copy Markdown
Member

Mirrors the ResolveReadyToRunCompilers change from dotnet/runtime#127578 for the SDK copy of the task.

Android RIDs now resolve to Crossgen2 TargetOS=android instead of falling through to the Linux/Bionic match, allowing runtime Crossgen2 target normalization to select Android-specific ARM ABI handling.

Map Android RIDs to the android Crossgen2 target OS when resolving ReadyToRun compilers so Android ARM can use the runtime's Android-specific ABI handling.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the SDK’s ResolveReadyToRunCompilers task to recognize Android RIDs as TargetOS=android for Crossgen2, aligning with dotnet/runtime behavior so Crossgen2 can apply Android-specific target normalization (notably ARM ABI handling).

Changes:

  • Add "android" to the portable RID matching list used to derive Crossgen2 TargetOS.
  • Map the matched portable platform "android" to Crossgen2 TargetOS="android".

@simonrozsival simonrozsival merged commit 966882b into main May 20, 2026
25 checks passed
@simonrozsival simonrozsival deleted the dev/srozsival/android-arm-changes branch May 20, 2026 14:07
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 11.0-preview6 milestone May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants