Use pattern matching in PayloadHelper.cs to improve readability #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves the readability using c# pattern matching fixes dotnet#25
|
|
|
this was the last occurrence of this issue i found |
suhsteve
reviewed
Dec 6, 2021
| if (type == typeof(byte[])) | ||
| { | ||
| return s_byteArrayTypeId; | ||
| } | ||
|
|
||
| if (type == typeof(int[]) || |
There was a problem hiding this comment.
Shouldn't this be included in the switch expression ?
There was a problem hiding this comment.
this is a super long logical expression that would not fit well into that format
| { | ||
| return s_timestampTypeId; | ||
| } | ||
| _ when typeof(IJvmObjectReferenceProvider).IsAssignableFrom(type) => s_jvmObjectTypeId, |
There was a problem hiding this comment.
I think some of these lines are too long. Can you check https://github.com/dotnet/spark/blob/main/docs/coding-guidelines/csharp-coding-style.md ?
|
Looks like builds are failing. Can you look into it ? |
|
i fixed one reason and the other one was there before |
|
Hi @sneznaj, are you still working on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the readability using c# pattern matching
fixes #25