Skip to content

Adding Hardware acceleration version of Queries 1 and 8 in csharp #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Adding Hardware acceleration version of Queries 1 and 8 in csharp #274

wants to merge 12 commits into from

Conversation

Niharikadutta
Copy link
Collaborator

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

@imback82
Copy link
Contributor

#291 should unblock this when it's merged to master.

@imback82 imback82 added the enhancement New feature or request label Oct 13, 2019
imback82
imback82 reviewed Jan 11, 2020
View reviewed changes
imback82
imback82 reviewed Jan 23, 2020
View reviewed changes
benchmark/csharp/Tpch/TpchFunctionalQueries.cs
@@ -227,12 +243,9 @@ internal void Q8()
.Show();
}

internal void Q8v()
internal void Q8aCommon(Func<Column, Column, Column> discPrice)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't Q8 call this as well?

Base automatically changed from master to main March 18, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@imback82 imback82 imback82 left review comments

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

@Niharikadutta Niharikadutta

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Niharikadutta @imback82