Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose logger for override by consumer #542

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Expose logger for override by consumer #542

wants to merge 1 commit into from

Conversation

thrixton
Copy link
Contributor

@thrixton thrixton commented Jun 9, 2020

Expose LoggerServiceFactory and ILoggerService as public for override by consuming applications

Fixes #473

@imback82 imback82 mentioned this pull request Jun 10, 2020
Open
@sunildixit
Copy link
Contributor

Is there a reason this is still out here? Can this be merged?

@sunildixit
Copy link
Contributor

@imback82 Is there a reason this is held back at this time?

@imback82
Copy link
Contributor

imback82 commented Mar 1, 2021

@sunildixit The reason was to fix this in a right way: #473 (comment)

There is a workaround if you need to access these: #473 (comment)

Base automatically changed from master to main March 18, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST]: Allow injection of custom LoggerService
3 participants
@thrixton @sunildixit @imback82