Fixed "Value cannot be null. (Parameter 'args')" #5453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mconnew
reviewed
May 19, 2025
| } | ||
|
|
||
| return string.Format(res, args); |
There was a problem hiding this comment.
This code was copied from here. The try original try/catch block still needs to wrap the string.Format call.
There was a problem hiding this comment.
Thank you. I just pushed another commit with the original try/catch block to wrap the string.Format call.
mconnew
approved these changes
May 21, 2025
|
Your branch was stale causing test failures, so I rebased it to our main with your changes and pushed it to your fork. The tests should pass now. Once they've passed, I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5452