Skip to content

Conversation

@Epica3055
Copy link
Member

@Epica3055 Epica3055 commented Sep 12, 2025

/backport PR13834 to release/10.0

Fixes #13829

Proposed changes

  • Remove BackColorSet, ForeColorSet. use DefaultForeColor,DefaultBackColor to decide whether we should use ButtonBase.BackColor or ButtonBase.ForeColor

Screenshots

After

image image image image

Test methodology

  • manual
Microsoft Reviewers: Open in CodeFlow

…tyle is Flat/Popup and Form.ForeColor Is set (dotnet#13834)

* a simple rename

* remove BackColorSet, ForeColorSet.  use DefaultForeColor,DefaultBackColor to compare

* Revert "remove BackColorSet, ForeColorSet.  use DefaultForeColor,DefaultBackColor to compare"

This reverts commit 5871984.

* Revert "a simple rename"

This reverts commit 19fc8bf.

* fix comments. use another approach.
@Epica3055 Epica3055 requested a review from a team as a code owner September 12, 2025 09:02
@github-actions github-actions bot added the area-DarkMode Issues relating to Dark Mode feature label Sep 12, 2025
@Epica3055 Epica3055 changed the title Fix 13829 Dark Mode: Button ForeColor ignored in Dark Mode when FlatS… [release/10.0] Fix 13829 Dark Mode: Button ForeColor ignored in Dark Mode when FlatS… Sep 12, 2025
@Epica3055 Epica3055 changed the title [release/10.0] Fix 13829 Dark Mode: Button ForeColor ignored in Dark Mode when FlatS… [release/10.0] Fix 13829 Dark Mode: Button ForeColor ignored in Dark Mode when FlatStyle is Flat/Popup and Form.ForeColor Is set Sep 12, 2025
@codecov
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.91947%. Comparing base (bff8288) to head (3c849e0).
⚠️ Report is 4 commits behind head on release/10.0.

❗ There is a different number of reports uploaded between BASE (bff8288) and HEAD (3c849e0). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (bff8288) HEAD (3c849e0)
Debug 3 2
test 1 0
Additional details and impacted files
@@                   Coverage Diff                   @@
##           release/10.0      #13864          +/-   ##
=======================================================
- Coverage      77.09771%   51.91947%   -25.17825%     
=======================================================
  Files              3273        2064        -1209     
  Lines            644931      287892      -357039     
  Branches          47692       42109        -5583     
=======================================================
- Hits             497227      149472      -347755     
+ Misses           144031      135531        -8500     
+ Partials           3673        2889         -784     
Flag Coverage Δ
Debug 51.91947% <0.00000%> (-25.17825%) ⬇️
integration 18.98592% <0.00000%> (+0.00049%) ⬆️
production 51.91947% <0.00000%> (+0.01296%) ⬆️
test ?
unit 49.34072% <0.00000%> (+0.01627%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LeafShi1 LeafShi1 closed this Sep 17, 2025
@LeafShi1
Copy link
Member

This change will be in .net11

@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-DarkMode Issues relating to Dark Mode feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants