Enable building WPF using VS 2026 #11309
Conversation
dotnet-policy-service
bot
added
the
PR
There was a problem hiding this comment.
Pull request overview
This PR upgrades the WPF build infrastructure from Visual Studio 2022 to Visual Studio 2026 preview to resolve pipeline failures. The changes ensure compatibility with the newer toolchain and SDK versions required for VS 2026.
Key changes include:
- Upgrading MSVC toolset from v143 (VS 2022) to v145 (VS 2026)
- Updating Windows SDK from version 10.0.19041.0 to 10.0.26100.0 (Windows 11 24H2)
- Migrating Azure pipeline agents to windows.vs2026preview.scout.amd64 images
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| eng/WpfArcadeSdk/tools/Wpf.Cpp.props | Updates PlatformToolset to v145 and WindowsTargetPlatformVersion to 10.0.26100.0 |
| src/Microsoft.DotNet.Wpf/redist/VCRuntime/VCRuntime.vcxproj | Updates VCRedist CRT folder references from VC143 to VC145 |
| azure-pipelines.yml | Updates internal build agent image to VS 2026 preview |
| azure-pipelines-pr.yml | Updates both public and internal PR build agent images to VS 2026 preview |
| Documentation/wpf.vsconfig | Adds Windows 11 SDK 26100 component while retaining Windows 10 SDK 19041 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <PlatformToolset>v143</PlatformToolset> | ||
| <PlatformToolset>v145</PlatformToolset> | ||
|
|
||
| <!-- 17134 is Windows 10 v1903 (19H1) SDK --> |
There was a problem hiding this comment.
The comment is outdated and inaccurate. The SDK version 17134 corresponds to Windows 10 v1803 (April 2018 Update, not v1903), and the code now uses version 10.0.26100.0 which is the Windows 11 24H2 SDK. Please update the comment to accurately reflect the current SDK version, e.g., <!-- 26100 is Windows 11 24H2 SDK -->
| <!-- 17134 is Windows 10 v1903 (19H1) SDK --> | |
| <!-- 26100 is Windows 11 24H2 SDK --> |
| <VCProjectVersion>15.0</VCProjectVersion> | ||
| <CharacterSet>Unicode</CharacterSet> | ||
|
|
||
| <!-- v143 = Visual Studio 2022 --> |
There was a problem hiding this comment.
The comment still references Visual Studio 2022, but the toolset has been updated to v145 which corresponds to Visual Studio 2026. Please update the comment to reflect this change, e.g., <!-- v145 = Visual Studio 2026 -->
| <!-- v143 = Visual Studio 2022 --> | |
| <!-- v145 = Visual Studio 2026 --> |
harshit7962
left a comment
harshit7962
left a comment
There was a problem hiding this comment.
Changes LGTM, comments might need changes (as pointed out by GH copilot)
| ${{ if eq(variables['System.TeamProject'], 'public') }}: | ||
| name: NetCore-Public | ||
| demands: ImageOverride -equals windows.vs2022.amd64.Open | ||
| demands: ImageOverride -equals windows.vs2026preview.scout.amd64.Open |
There was a problem hiding this comment.
Is the only preview version available ?
There was a problem hiding this comment.
Looks like 18.0.0 release has a scouting queue: https://dev.azure.com/dnceng/internal/_wiki/wikis/DNCEng%20Services%20Wiki/1572/VS2026-Upgrade-Schedule
Fixes
Pipeline failures of #11288
Description
This PR consists of three small sections :
Customer Impact
CI Builds will work as expected
Regression
No
Testing
--
Risk
Minimal
Microsoft Reviewers: Open in CodeFlow