Skip to content

adding victor's song#95

Open
VictorManzanilla wants to merge 2 commits intomainfrom
94-add-victor-song
Open

adding victor's song#95
VictorManzanilla wants to merge 2 commits intomainfrom
94-add-victor-song

Conversation

@VictorManzanilla
Copy link

No description provided.

@VictorManzanilla VictorManzanilla linked an issue Apr 16, 2025 that may be closed by this pull request
@Ritumka Ritumka self-requested a review April 17, 2025 17:09
Copy link
Contributor

@Ritumka Ritumka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Fix the indentation issue and resolve the merge conflict, please.

You need to re-request my review so I can approve your changes.

index.html Outdated
</div>

<p class="mb-1">Kylie Minogue</p>
<small class="text-body-secondary">Submitted by Victor Manzanilla</small>
Copy link
Contributor

@Ritumka Ritumka Apr 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To pass the test this part should be formatted like this:

<small class="text-body-secondary">
   Submitted by Victor Manzanilla
</small>

You can install the "Prettier - Code formatter" extension (by Prettier) in your Codespace or locally. Then, simply two-finger click (or right-click on Windows) and select Format Document. It will automatically format your files according to the defined rules.

Copy link
Contributor

@borvux borvux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree with margo

Copy link
Contributor

@borvux borvux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-04-21 at 12 41 20 PM

looks good, and for future reference, don't forget to add a newline to every file, since it's a common convention that improves compatibility with tools, keeps version control diffs clean, and aligns with POSIX standards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Victor's favorite song

4 participants